Optimize configuration loading: cache JSON #218
Merged
+21
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved environment variable parsing to a dedicated loadConfig() function, called only once during initialization of the global g_jsonConfig. - Updated GetJson() to return the cached JSON object, preventing repetitive parsing of environment variables on each access. - Improved performance and simplified configuration data access. Replace <stdio.h> with <cstdlib> and <cstdio> - Updated include directives to use modern C++ headers. - The new headers place standard library functions in the std namespace, enhancing compatibility and type safety as recommended by modern C++ standards.
|
Oh, see the almost same fixes in another PR |
|
Thanks for the PR, I'll try to merge what I can from the conflict 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace <stdio.h> with and