Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide all progress bars #65

Closed
D4Vinci opened this issue Nov 2, 2024 · 2 comments
Closed

Hide all progress bars #65

D4Vinci opened this issue Nov 2, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@D4Vinci
Copy link
Contributor

D4Vinci commented Nov 2, 2024

Describe the feature:

Hi, I appreciate that this library is still not ready for production, but can't we have a verbose mode to hide all progress bars, like these?

Screenshot 2024-11-02 at 4 16 35 PM

I think it's better to have a command line like camoufox fetch to download all browserforge files and the rest. I plan to use Camoufox inside a web scraping library, so having progress bars would definitely hurt the user experience for your library and mine.

I think adding all this logic inside camoufox fetch would be even better (like browserforge update for example)

@D4Vinci D4Vinci added the enhancement New feature or request label Nov 2, 2024
daijro added a commit that referenced this issue Nov 3, 2024
- Removed progress bars on addon download (shows as percent instead)
- Default addons are downloaded on `camoufox fetch`
@daijro
Copy link
Owner

daijro commented Nov 3, 2024

Hello,

In the latest commit, default addons are now downloaded on camoufox fetch. I've also removed the unnecessarily verbose progress bars when downloading addons.

@D4Vinci
Copy link
Contributor Author

D4Vinci commented Nov 3, 2024

Nice work dude! Let's close this ticket then.

@D4Vinci D4Vinci closed this as completed Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants