-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new API with useMutableSource #48
Conversation
Co-Authored-By: Adam Zmenak <adam.zmenak@gmail.com>
I implemented it as documented with the react-redux Context recipe, and it works (
|
@faceyspacey Hmm, is it possible for you to make a small reproduction in codesandbox? |
I will at some point, but I'm using a custom setup with a babel plugin that makes I've been meaning to show you how I'm doing it by making a small repro of this aspect of the system, so we can figure out how to memoize selectors across usages, as selectors in Respond are defined once upfront (not in component functions). I'll make the repro when I get to this point. If it's not occurring for you, it's likely due to my system. I have an idea of what would be causing. I'll make my system more normal, and see if that removes the issue...I just wanted to see if this is something you've come across. |
Not for me. Most likely, it's from somewhere around |
Although useMutableSource hasn't landed, let me merge this PR and update README to indicate this is still an experimental project. |
API is not based on Context. It's optional.
Check list: