Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.0.0-beta2 section to CHANGELOG.md #542

Merged
merged 4 commits into from
May 14, 2018

Conversation

rkeithhill
Copy link
Collaborator

Clean up various markdown linter warnings.

Let's use this PR for on-going tweaks to the CHANGELOG.md. Although I'm not anticipating making any more changes myself. Although I need to wrap up the README changes and tweak the Wiki on customizing your prompt function.

Should we shoot for a Feb 14th release of beta 2? I think we could easily pull that up if we wanted to.

@rkeithhill rkeithhill requested a review from dahlbyk January 30, 2018 01:54
@rkeithhill rkeithhill changed the title WIP - add 1.0.0-beta2 section WIP - add 1.0.0-beta2 section to CHANGELOG.md Jan 30, 2018
@rkeithhill rkeithhill mentioned this pull request Feb 20, 2018
13 tasks
@dahlbyk dahlbyk added this to the v1.0 milestone Apr 20, 2018
@dahlbyk dahlbyk changed the base branch from develop to master April 20, 2018 05:31
@dahlbyk dahlbyk force-pushed the rkeithhill/prep-beta2-changelog branch from 17bf4e1 to 610e0bd Compare May 13, 2018 20:34
@dahlbyk dahlbyk force-pushed the rkeithhill/prep-beta2-changelog branch from 610e0bd to 9cabba6 Compare May 13, 2018 20:42
@dahlbyk
Copy link
Owner

dahlbyk commented May 13, 2018

@rkeithhill I've rebased this changes onto master, with a bit of cleanup and the newest changes. Please have a look at the latest commit (and the full changelog).

@dahlbyk
Copy link
Owner

dahlbyk commented May 13, 2018

Weird, any idea why the reference-style links don't seem to be working?

CHANGELOG.md Outdated
- Changing `Write-VcsStatus`, `Write-GitStatus` and `Write-Prompt` to return a string rather than write to host when
the host supports ANSI escape sequences.
which support classes, enabling the enhanced structure of `$GitPromptSettings`,
and writing prompt strings using [ANSI escape sequences](ansi-esc-code) /
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this [ANSI escape sequences](ansi-esc-code) to this [ANSI escape sequences][ansi-esc-code] and it should work. Ditto for the other two.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh. Thanks.

Any other feedback?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than those three links, it looks good!

@dahlbyk dahlbyk force-pushed the rkeithhill/prep-beta2-changelog branch from 9cabba6 to 04cda24 Compare May 14, 2018 03:06
@dahlbyk dahlbyk changed the title WIP - add 1.0.0-beta2 section to CHANGELOG.md Add 1.0.0-beta2 section to CHANGELOG.md May 14, 2018
@dahlbyk dahlbyk merged commit c59689e into master May 14, 2018
@dahlbyk dahlbyk deleted the rkeithhill/prep-beta2-changelog branch May 14, 2018 03:11
@dahlbyk dahlbyk mentioned this pull request May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants