Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSharp output with more consistency, robustness and more understandable code #427

Closed
10 tasks done
dadhi opened this issue Oct 24, 2024 · 0 comments
Closed
10 tasks done
Assignees
Milestone

Comments

@dadhi
Copy link
Owner

dadhi commented Oct 24, 2024

Should work for at least the current Tests output.

List of problems to solve:

  • In the ternary expression, the second branch after : is not indented, but should be in Issue196_AutoMapper_tests_are_failing_when_using_FEC.Test_the_tmp_var_block_reduction.
  • In some ternary expression, the second branch on the new line is double indented in Issue419_The_JIT_compiler_encountered_invalid_IL_code_or_an_internal_limitation.Original_Case_2.
  • In catch the expression after return is in parens, but it should not in TryCatchTests.Can_handle_the_exception_and_return_result_from_TryCatch_block.
  • The body of the Action in the Invoke expression is double indented, but should not in NestedLambdaTests.Issue401_What_happens_if_inlined_invocation_of_lambda_overrides_the_same_parameter.
  • In the nested lambda with multiply parameters, the parameters are double indented, but should be only once.
  • The expression body of the function is in parens but should not be Issue196_AutoMapper_tests_are_failing_when_using_FEC.Test_the_tmp_var_block_reduction.
  • Some expressions are still in parens after the return in Issue390_405_406_Mapster_tests.Issue390_Test_extracted_mapping_code.
  • Arguments of the Invoke are not indented but should be in Issue156_InvokeAction.InvokeFuncConstantIsSupported
  • In the assignment, the right value after = on the new line is not indented, but should be.
  • Switch cases returning values should use return keyword in Issue274_Failing_Expressions_in_Linq2DB.Test_case_2_Full_ExecutionEngineException
@dadhi dadhi added this to the v5.0.0 milestone Oct 24, 2024
@dadhi dadhi self-assigned this Oct 24, 2024
dadhi added a commit that referenced this issue Oct 25, 2024
dadhi added a commit that referenced this issue Oct 27, 2024
dadhi added a commit that referenced this issue Nov 7, 2024
dadhi added a commit that referenced this issue Nov 7, 2024
dadhi added a commit that referenced this issue Nov 8, 2024
dadhi added a commit that referenced this issue Nov 8, 2024
@dadhi dadhi closed this as completed in 64e3941 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant