Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests for 3.11 #34

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Run tests for 3.11 #34

merged 7 commits into from
Apr 12, 2023

Conversation

d5h
Copy link
Collaborator

@d5h d5h commented Apr 11, 2023

This mainly adds Python 3.10 and 3.11 for testing. It also has some other minor fixes listed below. It has no functionality changes so I won't push a new release for this.

Changes:

  • Runs tests for all major versions on Python from 3.7 to 3.11 in GHA
  • Updates mypy since the old version can't build the typed-ast extension with Python 3.11
  • Cleans up the test action so it doesn't try to run every nox session, only the ones for the Python version under test (much less noisy)
  • Fix a bug where pytest-asyncio wasn't installed by nox so one of the tests was skipped
  • Updates coverage because there was a bug in the old version which was making the test output noisy
  • Needed to format changes, and needed to update black, which formatted some irrelevant code
  • Increase test verbosity

Note: this PR doesn't actually cause test coverage to drop, despite what Codecov is reporting. Codecov's baseline is very old, I believe because they suspended my Codecov account due to inactivity. The coverage baseline it's using was prior to asyncio's addition.

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2023

Codecov Report

Merging #34 (4252b41) into master (30b5173) will decrease coverage by 4.69%.
The diff coverage is 91.23%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##            master      #34      +/-   ##
===========================================
- Coverage   100.00%   95.31%   -4.69%     
===========================================
  Files            7        7              
  Lines          211      363     +152     
  Branches        15       49      +34     
===========================================
+ Hits           211      346     +135     
- Misses           0       14      +14     
- Partials         0        3       +3     
Impacted Files Coverage Δ
src/grpc_interceptor/testing/dummy_client.py 91.36% <89.09%> (-8.64%) ⬇️
src/grpc_interceptor/server.py 95.08% <91.42%> (-4.92%) ⬇️
src/grpc_interceptor/exception_to_status.py 96.42% <95.65%> (-3.58%) ⬇️
src/grpc_interceptor/__init__.py 100.00% <100.00%> (ø)
src/grpc_interceptor/client.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@d5h d5h merged commit 454bc61 into master Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants