IO: Fix files not being deleted in Android/data despite using Shizuku/Root
#1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ku/Root The scan, e.g. listfiles or lookup, would use a different logic to check what access level is needed. Example: In the CorpseFinder, the scan would use `listFiles` on `Android/data` and the `Mode.AUTO` would resolve to `Mode.ADB` or `Mode.ROOT`. Either mode can see files in `Android/data` and return good results. But the deletion would always hit the `javaFile.parentFile?.canExecute() == true -> true` case and resolve `Mode.AUTO` to `Mode.NORMAL`, i.e. try normal access. Normal access wouldn't see the file in `Android/data` and then assume that it had already been deleted... :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scan, e.g. listfiles or lookup, would use a different logic to check what access level is needed. Example:
In the CorpseFinder, the scan would use
listFilesonAndroid/dataand theMode.AUTOwould resolve toMode.ADBorMode.ROOT. Either mode can see files inAndroid/dataand return good results. But the deletion would always hit thejavaFile.parentFile?.canExecute() == true -> truecase and resolveMode.AUTOtoMode.NORMAL, i.e. try normal access. Normal access wouldn't see the file inAndroid/dataand then assume that it had already been deleted... :(