Feature/tests timeouts #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
469efa4 to
cf191d6
Compare
bce0efb to
49d4f2b
Compare
d3af0ef to
b35dbb2
Compare
|
Let me know if there is no sense in a such wrapping for some tests |
configs/test_local.properties
Outdated
| @@ -25,3 +25,5 @@ test.ethereum.gasLimit=6000000 | |||
| # --------- Bitcoin --------- | |||
| test.bitcoin.walletPath=deploy/bitcoin/test-btc.wallet | |||
| test.bitcoin.blockStoragePath=deploy/bitcoin/blocks | |||
| # --------- Timeout (minutes) --------- | |||
| test.testTimeout=5 | |||
There was a problem hiding this comment.
I think we can hardcode this value.
There was a problem hiding this comment.
Done as a constant value In ConfigHelper
| newBalance | ||
| ) | ||
| assertTrue(btcNotaryInitialization.isWatchedAddress(btcAddress)) | ||
| assertTimeoutPreemptively(timeoutDuration) { |
There was a problem hiding this comment.
I don't think we need assertTimeoutPreemptively in every test. Can we use this construction in tests known to be long-running only?
2f9258f to
64cf7e6
Compare
|
Please, don't use force push for your branches, since it is impossible to view changes from the last review. |
Alexey-N-Chernyshov
approved these changes
Nov 30, 2018
01668ab to
f2d9919
Compare
Alexey-N-Chernyshov
pushed a commit
that referenced
this pull request
Dec 14, 2018
* Wrapped most of integration tests with awkward JUnit5 timeouts
Alexey-N-Chernyshov
pushed a commit
that referenced
this pull request
Dec 14, 2018
* Wrapped most of integration tests with awkward JUnit5 timeouts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added awkward integration tests timeouts.
Details:
junit-team/junit5#80 (comment)
https://blog.philipphauer.de/best-practices-unit-testing-kotlin/
On the one hand it is generally bad idea to use JUnit4 for Kotlin
On the other hand there is no convenient way to implement timeouts in JUnit5 yet
Usage Examples or Tests [optional]