-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Upper Model of OT Artifacts #329
Conversation
@aamedina can you give this a review / check? |
@@ -18808,7 +18886,7 @@ Legitimate emails from a sender may receive a lower trust rating over time if th | |||
rdfs:label "Sensor" ; | |||
rdfs:subClassOf :D3FENDCore, | |||
:DigitalInformationBearer ; | |||
:definition "In the broadest definition, a sensor is a device, module, machine, or subsystem that detects events or changes in its environment and sends the information to other electronics, frequently a computer processor." ; | |||
:definition "In the broadest definition, a sensor is a device, module, machine, or subsystem that detects events or changes in its environment and sends the information to other electronics, frequently a processor or logic solver." ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not good, please remove.
rdfs:seeAlso <https://www.rockwellautomation.com/en-us/support/documentation/technical/i-o/compact-5000-i-o-modules.html> ; | ||
:synonym "IO Module" . | ||
|
||
:OTPowerSupply a owl:Class ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a d3f:PowerSupply artifact that an OT Power Supply is a specialization of.
rdfs:isDefinedBy <https://csrc.nist.gov/glossary/term/controller> ; | ||
:definition "A device or program that operates automatically to regulate a controlled variable." . | ||
|
||
:OTEmbeddedComputer a owl:Class ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a definition.
@@ -168,6 +168,11 @@ | |||
rdfs:label "claims" ; | |||
rdfs:subPropertyOf :d3fend-catalog-object-property . | |||
|
|||
:communicates-with a owl:ObjectProperty ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a owl:SymmetricProperty, where if x communicates with y then y also communicates with x. Otherwise, perhaps the d3f:connects property is sufficient.
@@ -203,6 +208,11 @@ Moving forward different distinctions of kinds of has-part (contains) relationsh | |||
rdfs:subPropertyOf :d3fend-catalog-object-property ; | |||
rdfs:range owl:Thing . | |||
|
|||
:controls a owl:ObjectProperty ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ideally this would be a superproperty of d3f:manages, but I can see why you didn't choose that as the definition there is too specific to relating some thing x to a digital artifact y.
d3f:manages rdfs:subPropertyOf d3f:controls makes sense to me.
I think we should also add the inverse property (d3f:controlled-by).
@@ -957,6 +967,11 @@ Moving forward different distinctions of kinds of has-part (contains) relationsh | |||
rdfs:isDefinedBy <http://purl.obolibrary.org/obo/BFO_0000056> ; | |||
:definition "x participates-in y: The object x takes part in the event y, signifying that x contributes to or is affected by the event’s occurrence in some way." . | |||
|
|||
:powered-by a owl:ObjectProperty ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a subproperty of d3f:dependsOn, and also needs an inverse (d3f:powers).
No description provided.