This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Adds sandbox uri #190
Merged
Adds sandbox uri #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArtRand @susanxhuynh pls review. |
susanxhuynh
reviewed
Oct 3, 2017
docker/runit/service/spark/run
Outdated
| @@ -53,6 +53,7 @@ function configure_properties() { | |||
| add_if_non_empty spark.ssl.trustStorePassword "${SPARK_SSL_TRUSTSTOREPASSWORD}" | |||
| add_if_non_empty spark.ssl.protocol "${SPARK_SSL_PROTOCOL}" | |||
| add_if_non_empty spark.ssl.enabledAlgorithms "${SPARK_SSL_ENABLEDALGORITHMS}" | |||
| echo "spark.mesos.proxy.baseURL=../../mesos" >> /opt/spark/dist/conf/mesos-cluster-dispatcher.properties | |||
There was a problem hiding this comment.
Could you avoid hardcoding the filename (/opt/spark/dist/conf/mesos-cluster-dispatcher.properties)? Maybe store it in a variable? It's currently hardcoded in several different places in this file.
8b20321 to
b4aeed8
Compare
|
@susanxhuynh pls review, clear for merge I think. |
|
retest this please |
|
@ArtRand whats wrong with the internal sanity test? |
susanxhuynh
approved these changes
Oct 6, 2017
|
The "teamcity/sanity-test" was added by the infrastructure team to test something out. They said we could ignore it for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default enable the sandbox uri. Check at the bottom of the image the uri.