This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
[SPARK-370][SPARK-499] Change image to run as nobody #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanxhuynh
suggested changes
Sep 27, 2017
docker/Dockerfile
Outdated
| @@ -72,15 +72,18 @@ RUN ln -s /bin/grep /usr/bin/grep | |||
|
|
|||
| RUN ln -s /var/lib/runit/service/spark /etc/service/spark | |||
| RUN ln -s /var/lib/runit/service/nginx /etc/service/nginx | |||
| RUN mkdir -p /etc/hadoop | |||
There was a problem hiding this comment.
This is repeated in L. 60 above, one of them can be removed.
susanxhuynh
approved these changes
Sep 27, 2017
benclarkwood
suggested changes
Sep 27, 2017
docker/Dockerfile
Outdated
| @@ -76,11 +76,13 @@ RUN ln -s /var/lib/runit/service/nginx /etc/service/nginx | |||
| ADD dist /opt/spark/dist | |||
|
|
|||
| # Commenting these for now, because we're running Spark as root in strict mode | |||
benclarkwood
approved these changes
Sep 27, 2017
|
@susanxhuynh @ArtRand I am not so sure about nobody in general its a relic: https://lwn.net/Articles/695526/ although widely used... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Spark image that is used for running the Dispatcher, Drivers, and Executors runs as
rootmeaning that Marathon requires permissions to launch containers asrootwhen on a strict-mode cluster.Solution
Change default to
nobody, allow access to directories in the image necessary for running Spark and it's components (e.g. nginx).Tested
CI unit tests for basic functionality, manually on a strict-mode cluster (see JIRA for details) and manually against a Kerberized HDFS cluster
Manual tests