style: default values for connection

d-strobel · Oct 16, 2023 · c601be6 · c601be6
1 parent 79dc780
commit c601be6
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/connection/connection.go b/connection/connection.go
@@ -3,23 +3,11 @@ package connection
 import (
 	"context"
 	"errors"
-	"time"
 
 	"github.com/masterzen/winrm"
 	"golang.org/x/crypto/ssh"
 )
 
-const (
-	// WinRM default values
-	defaultWinRMPort     int           = 5986
-	defaultWinRMUseTLS   bool          = false
-	defaultWinRMInsecure bool          = true
-	defaultWinRMTimeout  time.Duration = 0
-
-	// SSH default values
-	defaultSSHPort int = 22
-)
-
 type Connection struct {
 	WinRM *winrm.Client
 	SSH   *ssh.Client

diff --git a/connection/kerberos.go b/connection/kerberos.go
@@ -11,7 +11,7 @@ type KerberosConfig struct {
 
 const (
 	// Default kerberos values
-	kerberosProtocolDefault = "http"
+	defaultKerberosProtocol = "http"
 )
 
 // winRMKerberosParams returns the neccessary parameters
@@ -22,7 +22,7 @@ func winRMKerberosParams(config *WinRMConfig) *winrm.Parameters {
 	params := winrm.DefaultParameters
 
 	// Set the protocol
-	kerberosProtocol := kerberosProtocolDefault
+	kerberosProtocol := defaultKerberosProtocol
 	if config.WinRMUseTLS {
 		kerberosProtocol = "https"
 	}

diff --git a/connection/ssh.go b/connection/ssh.go
@@ -16,6 +16,11 @@ type SSHConfig struct {
 	SSHPassword string
 }
 
+const (
+	// SSH default values
+	defaultSSHPort int = 22
+)
+
 func newSSHClient(config *SSHConfig) (*ssh.Client, error) {
 
 	// Assert

diff --git a/connection/winrm.go b/connection/winrm.go
@@ -18,6 +18,14 @@ type WinRMConfig struct {
 	WinRMKerberos *KerberosConfig
 }
 
+const (
+	// WinRM default values
+	defaultWinRMPort     int           = 5986
+	defaultWinRMUseTLS   bool          = false
+	defaultWinRMInsecure bool          = true
+	defaultWinRMTimeout  time.Duration = 0
+)
+
 func newWinRMClient(config *WinRMConfig) (*winrm.Client, error) {
 
 	// Assert