Merge pull request #35 from d-strobel/fix/local-group-update

fix: local.GroupUpdate cannot update empty description
d-strobel · Jan 12, 2024 · 51935fc · 51935fc
2 parents 566c4d2 + 23604de
commit 51935fc
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/windows/local/local_group.go b/windows/local/local_group.go
@@ -154,7 +154,12 @@ func (c *LocalClient) GroupUpdate(ctx context.Context, params GroupUpdateParams)
 		cmds = append(cmds, fmt.Sprintf("-Name '%s'", params.Name))
 	}
 
-	cmds = append(cmds, fmt.Sprintf("-Description '%s'", params.Description))
+	if params.Description == "" {
+		cmds = append(cmds, "-Description ' '")
+	} else {
+		cmds = append(cmds, fmt.Sprintf("-Description '%s'", params.Description))
+	}
+
 	cmd := strings.Join(cmds, " ")
 
 	// Run command

diff --git a/windows/local/local_group_test.go b/windows/local/local_group_test.go
@@ -308,7 +308,7 @@ func (suite *LocalUnitTestSuite) TestGroupUpdate() {
 			{
 				"assert with Name parameter",
 				GroupUpdateParams{Name: "Test"},
-				"Set-LocalGroup -Name 'Test' -Description ''",
+				"Set-LocalGroup -Name 'Test' -Description ' '",
 			},
 		}