-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Df 131 #39
Conversation
src/dataland_qa_lab/review/report_generator/yes_no_report_generator.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beim Testing ist mir aufgefallen, dass sehr viele Fehler auftreten bei der string to float conversion mit verschiedenen numerischen Werten, das können wir uns vielleicht nochmal anschauen. Außerdem sind sehr viele (unnötige) Kommentare drin und #noqa Statements, die sollten reduziert/so gut es geht entfernt werden.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ich habe dir an die entsprechenden files Kommentare geschrieben
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passt
DQL-<NUM>: <TITLE>
<DESCRIPTION>
✅ Pre-Merge Checklist
All boxes must be checked before the Pull Request is merged. This checklist has to be completed by the reviewer.
dev
environment has succeeded. If possible, ensure that the feature can be observed on the server.💾 Merge Checklist
DQL-<NUM>: <TITLE>