Skip to content

Commit

Permalink
fix: ensure no null values are saved as markdown
Browse files Browse the repository at this point in the history
  • Loading branch information
TilmanNiem committed Feb 4, 2025
1 parent 3d3ae22 commit 7068dba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/dataland_qa_lab/pages/text_to_doc_intelligence.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def get_markdown_from_dataset(data_id: str, relevant_pages_pdf_reader: pypdf.Pdf

new_document = ReviewedDatasetMarkdowns(
data_id=data_id,
markdown_text=readable_text,
markdown_text=readable_text if not None else "",
page_numbers=page_numbers,
last_saved=formatted_german_time,
last_updated=formatted_german_time,
Expand Down
2 changes: 1 addition & 1 deletion tests/end_to_end/test_report_e2e.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
from unittest.mock import ANY, MagicMock, patch

import mock_constants
from dataland_qa.models.qa_report_data_point_verdict import QaReportDataPointVerdict
from dataland_qa.models.qa_report_meta_information import QaReportMetaInformation

from clients.qa.dataland_qa.models.qa_report_data_point_verdict import QaReportDataPointVerdict
from dataland_qa_lab.database.database_engine import delete_entity
from dataland_qa_lab.database.database_tables import ReviewedDataset
from dataland_qa_lab.dataland.provide_test_data import get_company_id, upload_dataset, upload_pdf
Expand Down

0 comments on commit 7068dba

Please sign in to comment.