sonar fix v2

d-fine · Nov 21, 2024 · 0215661 · 0215661
1 parent 2b10d54
commit 0215661
Showing 1 changed file with 19 additions and 16 deletions.
diff --git a/tests/dataland/test_dataland_client.py b/tests/dataland/test_dataland_client.py
@@ -10,13 +10,27 @@
 def test_dataland_connectivity() -> None:
     client = config.get_config().dataland_client
     resolved_companies = client.company_api.get_companies(chunk_size=1)
+    assert len(resolved_companies) > 0
 
-    dataland_client = da.get_config().dataland_client
 
-    dataset_by_year = qa.get_dataset_by_year(company_id="4423c691-0436-423f-abcb-0a08127ee848", year="2024")
+def test_dummy_get_data() -> None:
 
-    dataset_section426 = dataset_by_year.data.general.general.nuclear_energy_related_activities_section426
+    company_id = "4423c691-0436-423f-abcb-0a08127ee848"
+    year = "2024"
+    qa.get_all_company_datasets(company_id=company_id)
+    qa.get_data_id_by_year(company_id=company_id, year=year)
+    qa.get_dataset_by_year(company_id=company_id, year=year)
+    qa.get_value1_by_year(company_id=company_id, year=year)
+    qa.get_datasource_reference_bytes(company_id=company_id, year=year)
+
+    assert int(year) == 2024
+
+
+def test_dummy_data_extraction() -> None:
 
+    dataland_client = da.get_config().dataland_client
+    dataset_by_year = qa.get_dataset_by_year(company_id="4423c691-0436-423f-abcb-0a08127ee848", year="2024")
+    dataset_section426 = dataset_by_year.data.general.general.nuclear_energy_related_activities_section426
     file_id = dataset_section426.data_source.file_reference
 
     pdf = dataland_client.documents_api.get_document(file_id)
@@ -25,17 +39,6 @@ def test_dataland_connectivity() -> None:
 
     data = da.get_relevant_page_of_pdf(1, pdf_reader)
     text = da.extraxt_text_of_pdf(data)
-    da.extract_section_426(text)
-    assert len(resolved_companies) > 0
-
-
-def test_dummy_get_data() -> None:
-    company_id = "4423c691-0436-423f-abcb-0a08127ee848"
-    year = "2024"
-    qa.get_all_company_datasets(company_id=company_id)
-    qa.get_data_id_by_year(company_id=company_id, year=year)
-    qa.get_dataset_by_year(company_id=company_id, year=year)
-    qa.get_value1_by_year(company_id=company_id, year=year)
-    qa.get_datasource_reference_bytes(company_id=company_id, year=year)
+    result = da.extract_section_426(text)
 
-    assert True
+    assert result is not None