Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

features should not require users to manually include dependencies #36

Closed
tamird opened this issue Nov 7, 2023 · 1 comment · Fixed by #37
Closed

features should not require users to manually include dependencies #36

tamird opened this issue Nov 7, 2023 · 1 comment · Fixed by #37

Comments

@tamird
Copy link
Contributor

tamird commented Nov 7, 2023

See the features section of the README.

I think the usual pattern for this is:

  • create a "runtime" crate with optional dependencies on log and trace which are reexported.
  • add a dependency from test-log to "runtime". trace and log features enable "runtime"/log and "runtime"/trace, respectively.
  • from test-log, refer to log and trace as "runtime"::log and "runtime"::trace, respectively.

This would produce a nicer user experience.
@d-e-s-o
Copy link
Owner

d-e-s-o commented Nov 9, 2023

That sounds good to me. Feel free to open a pull request if you have time to work on it.

@tamird tamird mentioned this issue Nov 19, 2023
Merged
d-e-s-o pushed a commit that referenced this issue Nov 24, 2023
@tamird @d-e-s-o
Automatically include dependencies
708e52c 
- Move macros to a new test-log-macros crate.
- Export env_logger and tracing_subscriber from the test-log crate.
- Macros emit test_log::{env_logger,tracing_subscriber} references.

Removes the need for users to explicitly depend on additional crates.

Fixes #36.
d-e-s-o pushed a commit that referenced this issue Nov 25, 2023
@tamird @d-e-s-o
Automatically include dependencies
c94977b 
- Move macros to a new test-log-macros crate.
- Export env_logger and tracing_subscriber from the test-log crate.
- Macros emit test_log::{env_logger,tracing_subscriber} references.

Removes the need for users to explicitly depend on additional crates.

Fixes #36.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically include dependencies tamird/test-log
2 participants
@tamird @d-e-s-o