Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache bounding box calculations #1196

Closed
maxkfranz opened this issue Dec 15, 2015 · 4 comments
Closed

Cache bounding box calculations #1196

maxkfranz opened this issue Dec 15, 2015 · 4 comments
Labels
performance Improving speed and memory usage priority-1-high
Milestone
2.7.0

Comments

@maxkfranz
Copy link
Member

Bounding boxes are frequently used in layouts, rendering, etc.

They are expensive, so it would be nice to cache them.
@maxkfranz maxkfranz added enhancement priority-1-high performance Improving speed and memory usage labels Dec 15, 2015
@maxkfranz maxkfranz added this to the 2.6.0 milestone Dec 15, 2015
maxkfranz added a commit that referenced this issue Dec 15, 2015
@maxkfranz
- calculate rendered styles with a dirty flag (makes bb calcs more ef…
6793546 
…ficient #1196 and makes ren'style calcs faster #1194)

- fixes rendering sync issues with dynamic rendered style calc #1194
- use * event namespace to prevent users from killing listeners used by ren'style calc #1194
maxkfranz added a commit that referenced this issue Dec 15, 2015
@maxkfranz
fixes accounting for labels in bb and improves compound support re. u…
7816705 
…pdateCompoundBounds() #1194 #1196
@maxkfranz
Copy link
Member Author

Seems to be working OK

@maxkfranz
Copy link
Member Author

TODO The cache needs to be invalidated in the core level rather than the renderer. Otherwise, headless instances can get invalid values.

@maxkfranz maxkfranz reopened this Feb 2, 2016
@maxkfranz
Copy link
Member Author

TODO the bounding box needs to take into account the overlay

@maxkfranz
Copy link
Member Author

Takes into account overlay in texture cache changes

The BB cache is invalidated on headless instances automatically now

maxkfranz added a commit that referenced this issue Feb 9, 2016
@maxkfranz
fixes bbs for textures #1196 and shared texture caches working well w…
c5b6677 
…/ invalidation (needs border of caches fixed)
maxkfranz added a commit that referenced this issue Feb 19, 2016
@maxkfranz
- improve bb calc caching to account for options (e.g. w/ or w/o labels)
e15a1e9 
- improve bb calc perf for default case ele.boundingBox() as used by renderer -- speeds up texture caching
- improve bb calc perf re. general overhead for collection creation and rendered style recalc
- batch redraw requests from dequeuing texture requests (increases time available for calcs)
- tweaks to texture params
- dequeue textures before redraw => get some of them in current frame
- request redraw when queueing only if not already before draw
- animations should only invalidate caches if style is updated (or node pos for edges)

refs #593 #1196
@maxkfranz maxkfranz mentioned this issue Apr 4, 2016
Closed
1 task
maxkfranz added a commit that referenced this issue Apr 28, 2016
@maxkfranz
fix bounding box cache keys causing ele distortions in texture caches #…
a814966 
…593 #1196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Improving speed and memory usage priority-1-high
Projects
None yet
Milestone
2.7.0
Development

No branches or pull requests
1 participant
@maxkfranz