Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Replication Slot Resource #70

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Add Replication Slot Resource #70

merged 2 commits into from
Jun 21, 2021

Conversation

BarnabyShearer
Copy link
Contributor

A PG resource that seems to fit very well with being managed by TF.

https://www.postgresql.org/docs/current/view-pg-replication-slots.html

(Hope it is okay to PR a new feature; please let me know if you would like anything changed).

A PG resource that seems to fit very well with being managed by TF.

https://www.postgresql.org/docs/current/view-pg-replication-slots.html
@cyrilgdn
Copy link
Owner

Thanks @BarnabyShearer for your work on that. No problem with PR for new features, I'll take a look as soon as I can.

@cyrilgdn cyrilgdn self-requested a review April 12, 2021 21:25
Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BarnabyShearer

Thanks and sorry for the review delay.

The code looks good to me 👍

I never played with logical replication TBH so I trust you and the tests on that.

website/docs/r/postgresql_replication_slot.markdown Outdated Show resolved Hide resolved
@cyrilgdn cyrilgdn merged commit b12236a into cyrilgdn:master Jun 21, 2021
@cyrilgdn
Copy link
Owner

@BarnabyShearer This has just been released in v1.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants