add idle_in_transaction_session_timeout support to role #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilgdn
approved these changes
Mar 12, 2021
There was a problem hiding this comment.
Hi @colesnodgrass ,
Thanks for your work on that and sorry for the response delay.
I wanted to check before if we can rewrite a bit how we managed these settings.
I've just tried something but it's a bit more complex than I thought.
So we can merge your patch 👍
|
It looks like there's no docs for this change so it's not shown here. Does this want adding? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set the
idle_in_transaction_session_timeoutattribute on the role. This behaves similarly to thestatement_timeoutattribute and is based on how support for thestatement_timeoutattribute was implemented in this provider.