Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create temporary file with Google credential for terraformcloud #249

Merged
merged 4 commits into from
Nov 19, 2022

Conversation

felipe-minka
Copy link
Contributor

This includes the following PR and the requested changes
#180

@chris-minka
Copy link
Contributor

Hi @cyrilgdn. Any chance we could get this merged? It fixes #138.

Also, thank you for creating this provider!

@KrustyHack
Copy link

Ay,

I'm facing this problem too with Terraform Cloud. This fix would be very appreciate in our side ! 👍

@Klaitos
Copy link

Klaitos commented Nov 7, 2022

Definitively need this one to be merged too !

@cyrilgdn cyrilgdn self-requested a review November 17, 2022 23:10
@cyrilgdn
Copy link
Owner

Hi @felipe-minka ,

Sorry I was off the project for a while; thanks a lot for the PR 👍

Could you just merge master so it will trigger the tests again (normally I'm able to trigger them directly on the PR but I don't know why the button does not appear here 🤔 )

I tried, but don't have the right to push on your branch.

@chris-minka
Copy link
Contributor

Hi @cyrilgdn. We are glad you are back! I had permissions to merge master so it is done now and awaiting workflow approval. FYI @felipe-minka.

Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks 👍

@cyrilgdn cyrilgdn merged commit 7716c76 into cyrilgdn:master Nov 19, 2022
@adamlc
Copy link

adamlc commented Nov 23, 2022

Thanks for this, just come across the same problem in Terraform Cloud. Looking forward to a new official release :)

@cyrilgdn
Copy link
Owner

This has been released in v1.18.0

gdubicki added a commit to gdubicki/terraform-provider-postgresql that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants