Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function arg types support #228

Merged
merged 4 commits into from
Mar 18, 2023

Conversation

marvin-kolja
Copy link
Contributor

Fixes #227

* This new test will check if passing a function with arg types will work correctly.
* wrap args with `pq.QuoteIdentifier`
* wrap args with `pg.QuoteLiteral` instead of `pq.QuoteIdentifier`
@cyrilgdn cyrilgdn self-requested a review July 20, 2022 20:44
@edbighead
Copy link

hey @cyrilgdn, do you think it can be merged?

@marvin-kolja
Copy link
Contributor Author

marvin-kolja commented Nov 9, 2022

hey @cyrilgdn, do you think it can be merged?

@edbighead If you need that feature right now you can use our forked provider (we try to keep that updated with the master until #129 and #228 are merged): https://registry.terraform.io/providers/Mietz-GmbH/postgresql/1.16.1-jumphost-2

Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your fix, and sorry for the delay 😅 Didn't have much time to devote to this provider :(

@cyrilgdn cyrilgdn merged commit fbb747b into cyrilgdn:master Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Function Overloading
3 participants