Use docker healthcheck #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a docker healthcheck with pg-isready instead of a custom bash script. It's just one thing less to maintain. Also see: - https://www.postgresql.org/docs/9.4/app-pg-isready.html - https://docs.docker.com/engine/reference/builder/#healthcheck
This fixes the following error message. ``` Fix `FATAL: role "root" does not exist` ``` Also see: - https://docs.docker.com/engine/reference/builder/#user - https://github.com/docker-library/postgres/blob/3bb4804/14/bullseye/Dockerfile#L23
|
@boekkooi-lengoo Thanks, I discovered Docker health checks only a couple of months ago and wanted to do it here 👍 |
|
|
SpencerBinXia
pushed a commit
to SpencerBinXia/terraform-provider-postgresql
that referenced
this pull request
Feb 11, 2022
* Use docker healthcheck Use a docker healthcheck with pg-isready instead of a custom bash script. It's just one thing less to maintain. Also see: - https://www.postgresql.org/docs/9.4/app-pg-isready.html - https://docs.docker.com/engine/reference/builder/#healthcheck * Set USER This fixes the following error message. ``` Fix `FATAL: role "root" does not exist` ``` Also see: - https://docs.docker.com/engine/reference/builder/#user - https://github.com/docker-library/postgres/blob/3bb4804/14/bullseye/Dockerfile#L23 * Use docker compose instead of docker-compose * Update terraform SDK libs Co-authored-by: Cyril Gaudin <cyril.gaudin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and Happy Holidays (or I hope they where),
This PR removes
tests/wait-postgres-docker.shin favor of using a docker healthcheck with pg-isready instead.Thanks for reviewing this and have a great day!
Also see: