Drop connections before drop database

[p4cket]

Hey,
when you try to drop database in usage psql will error with message: "pq: cannot drop the currently open database
" or similar.

For psql 13+ there is new option for drop force https://www.postgresql.org/docs/13/sql-dropdatabase.html
for older we need kill connections manually.

[cyrilgdn]

Thanks for this PR @p4cket , TIL the new WITH FORCE option 😊 👍

As I said in comment, it should be an option (new force_drop field in postgresql_database for example). Otherwise it can be risky to drop a database if there's still clients using it.

[cyrilgdn]

Don't know why Travis didn't run 🤔

[cyrilgdn]

so do you thikn @cyrilgdn we can keep it with enforcing as terraform by default is giving us lifecycle ?

@p4cket Sorry I thought I already answered to you 🤦‍♂️

Yes, I asked for a third party advice on this discussion and you're right, we can force drop by default.

I'll just put a warning in a the CHANGELOG.

I allowed myself to fix the SQL errors, I wanted to create a test to assert the with force is working but it's not as easy as I thought to have a connected user on the database when the tests drops it. The existing tests already showed that there were errors in the code though.

If you want to have a look at my fixes and review it?

[cyrilgdn]

@p4cket FYI, this has just been released in v1.10.0