allow empty list for postgresql_default_privileges #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilgdn
approved these changes
Aug 22, 2021
There was a problem hiding this comment.
Hi @alec-rabold ,
Thanks a lot for your work on this 👍
I allowed myself to duplicate the step you created in the tests to add it also at the end, so it asserts that privileges are correctly revoked.
I also merged master to trigger the recently added golangci check.
|
@alec-rabold This has just been released in v1.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows passing in an empty list to the
privilegesargument for thepostgresql_default_privilegesresource. This should allow the resource to be used to only revoke certain privileges (e.g.functions/procedures).Closes #117