postgresql_grant: add foreign data wrapper and server support #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyrilgdn
requested changes
Aug 13, 2021
There was a problem hiding this comment.
Hi,
Thanks for your work 😊
I triggered the tests which fail because of the RDS test suite, for now we can ignore them (cf my comments).
I also think we can use the new objects settings (that has been merged in master today) instead of creating the 2 new fields foreign_data_wrapper and foreign_server
Co-authored-by: Cyril Gaudin <cyril.gaudin@gmail.com>
|
Hi, @cyrilgdn , |
cyrilgdn
approved these changes
Aug 22, 2021
There was a problem hiding this comment.
@kostiantyn-nemchenko Nice, LGTM 👍
Thanks again for your work!
|
This has just been released in v1.14.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104