Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_grant_option to postgresql_default_privileges #10

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Add with_grant_option to postgresql_default_privileges #10

merged 1 commit into from
Mar 12, 2021

Conversation

stawii
Copy link
Contributor

@stawii stawii commented Dec 2, 2020

This option exists in postgresql_grant but was missing in postgresql_default_privileges.
It is required to setup many things including Vault PostgreSQL Database Secrets Engine.

Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stawii Thanks for the patch 👍

Could you add this new field in one of the test so it asserts that the SQL is valid please?

@cyrilgdn cyrilgdn added the waiting-response Further information is requested label Jan 1, 2021
@stawii
Copy link
Contributor Author

stawii commented Jan 8, 2021

Sorry for late reply. There is no test in resource_postgresql_grant that I can take as an example.
I guess adding those tests might be another issue and out of scope of this PR ;)

@cyrilgdn
Copy link
Owner

cyrilgdn commented Jan 8, 2021

@stawii You can simply add the flag (to true) in this test and check the attribute here, even if will not assert that use has the grant option, it'll cover the code and assert the query is valid.

Copy link
Owner

@cyrilgdn cyrilgdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add the test.

@cyrilgdn cyrilgdn merged commit 2d2e9fb into cyrilgdn:master Mar 12, 2021
wilsonjackson referenced this pull request in Leafly-com/terraform-provider-postgresql Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-response Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants