Squashme: Fixes to pass linting test

cyrilgdn · Nov 9, 2021 · 2da59f5 · 2da59f5
1 parent a624d48
commit 2da59f5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/postgresql/helpers.go b/postgresql/helpers.go
@@ -286,10 +286,7 @@ func setToPgIdentList(schema string, idents *schema.Set) string {
 func setToPgIdentSimpleList(idents *schema.Set) string {
 	quotedIdents := make([]string, idents.Len())
 	for i, ident := range idents.List() {
-		quotedIdents[i] = fmt.Sprintf(
-			"%s",
-			ident.(string),
-		)
+		quotedIdents[i] = ident.(string)
 	}
 	return strings.Join(quotedIdents, ",")
 }

diff --git a/postgresql/resource_postgresql_grant.go b/postgresql/resource_postgresql_grant.go
@@ -638,7 +638,7 @@ func createRevokeQuery(d *schema.ResourceData) string {
 
 		if privileges.Len() == 0 || columns.Len() == 0 {
 			// No privileges to revoke, so don't revoke anything
-			query = fmt.Sprintf("SELECT NULL")
+			query = "SELECT NULL"
 		} else {
 			query = fmt.Sprintf(
 				"REVOKE %s (%s) ON TABLE %s FROM %s",

diff --git a/postgresql/utils_test.go b/postgresql/utils_test.go
@@ -356,7 +356,7 @@ func testCheckColumnPrivileges(t *testing.T, dbName, roleName string, tables []s
 	}
 
 	updateColumnValues := []string{}
-	for i, _ := range columns {
+	for i := range columns {
 		updateColumnValues = append(updateColumnValues, fmt.Sprint(columns[i], " = ", columnValues[i]))
 	}