-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Replace react-scripts example by nextjs example #867
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great job @MikeMcC399
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff. Thanks Mike!
Thanks guys! The difficult part is mostly figuring out what the right solution should be. Implementing it is often relatively straightforward. |
🎉 This PR is included in version 5.6.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR resolves #866 "Deprecations related to examples/react-scripts".
It implements the suggestion to replace examples/react-scripts by a new example based on Start a New React Project using Next.js.
The setup follows Create a Next.js App.
Changes
examples/nextjs
is added.examples/nextjs
instead of examples/react-scripts.examples/nextjs
tocypress@latest
instead of examples/react-scripts.Verification
Local
Execute:
and ensure
GitHub
Examine workflow log from https://github.com/cypress-io/github-action/actions/workflows/example-wait-on.yml and ensure that the jobs:
wait-on-nextjs
wait-using-custom-command
complete successfully.
wait-on
is usinglocalhost
showing that the workaround of127.0.0.1
needed for thereact-scripts
example is not necessary fornextjs