-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for sameSite in cookie-related commands #6828
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
165893e
to
c8df83d
Compare
User facing changelog
sameSite
viacy.setCookie()
.sameSite
to the objects yielded bycy.setCookie()
,cy.getCookie()
, andcy.getCookies()
. Users can enable this by setting theexperimentalGetCookiesSameSite
config key totrue
. In Cypress 5, this will be the default.Additional details
experimentalGetCookiesSameSite
no_restriction
while chrome's will beunspecified
Same-Site: None
cookie for cross origin requests #6757Same-Site: None
cookie for cross origin requests #6757 , but tests will need to be addedHow has the user experience changed?
PR Tasks
cypress-documentation
? DocumentsameSite
support for cookies commands cypress-documentation#2662type definitions
?cypress.schema.json
?