-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cypress init command #6249
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
6c3b99b
to
8ca8239
Compare
b6d3771
to
6d9f5c0
Compare
431aeca
to
22e277b
Compare
flaky test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the flag options match the naming convention of the configuration. So having --fixtures-folder
accept false
or a path as opposed to having 2 flags of --no-fixtures
and --fixtures-path
, what happens if they set both to contradicting values for example?
The Questions prompts are a really good start to the experience of what I was expecting for cypress init
. This will require much more extensive review from the team over the user experience and design decisions.
cypress/packages/server/lib/modes/init/scaffold/args.ts Lines 35 to 45 in 9bf8fab
|
We're going to have to dedicate some time to reviewing this implementation. At the moment we've decided to postpone a full review until a later sprint. |
It's fine. I can wait. |
It seems that |
cypress init
command to seed / scaffold test files on current directory #619User facing changelog
Scaffold Cypress with
cypress init
.Additional details
Options
Questions
Why was this change necessary?
Many developers wanted to control how Cypress is scaffolded.
What is affected by this change?
You can control how Cypress is scaffolded.
Any implementation details to explain?
prompts
rather thaninquirer
because it's small.How has the user experience changed?
Check above.
It doesn't change anything. It just adds
cypress init
command.PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?