-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] #2690 Decaffeinate action commands and their tests #6148
Conversation
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
@clarmso I know there isn't a great guide to how to run decaffeination, but since we do not squash the commits from a decaffeination PR, we prefer there be a minimal amount of commits, so conversion should be done in bulk instead of one by one (which creates 4 commits for each file. Then rebase any additional changes that are required by hand. Task definitions here: https://github.com/cypress-io/cypress/blob/v4.0-release/.vscode/tasks.json#L13:L13 So, for this commit find a way to bulk decaffeinate all together or split them up into smaller PRs if necessary. |
Ok. Will do! |
Converting the source code for the Cypress action commands and their tests from Coffeescript to Javascript is a part of the code maintenance. Having the source code in Javascript (and eventually Typescript) let the developers to utilize tools such as eslint and produce more robust code.
The command
npm run decaffeinate-bulk convert
has been used to convert the files.A part of #2690
User facing changelog
Convert the source code for the Cypress action commands from Coffeescript to Javascript.
Additional details
Other than the maintainers of the driver package, no one else should be affected by this change. Most of the conversion has been automatically generated by the bulk-decaffeinate script. In addition, the eslint issues discovered right after the conversion have been addressed.
How has the user experience changed?
There should be no changes in the commands' functionalities. If there are differences before and after this change, this PR should not be merged.
PR Tasks