fix(driver): type() can target activeElement #4953
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eps1lon
commented
Aug 8, 2019
| @@ -112,12 +112,13 @@ module.exports = function (Commands, Cypress, cy, state, config) { | |||
| const isMonth = $dom.isType(options.$el, 'month') | |||
| const isWeek = $dom.isType(options.$el, 'week') | |||
| const hasTabIndex = $dom.isSelector(options.$el, '[tabindex]') | |||
| const isCurrentlyFocused = $dom.isFocused($dom.getElements(options.$el)) | |||
There was a problem hiding this comment.
It might make more sense to squash these into a generic isFocusable.
IMO type() shouldn't be chainable and just apply to the focused element but that be a breaking change that requires a lot of manual focus() calls and you could always restrict this manually in your codebase.
|
@bkucera Great! Thanks for the update and the work on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tabindexspecified #2166 (vaguely related)The following fails right now:
force: truedoes not help. Only addingtabIndex="-1"to the button which shouldn't be required since a button is already focusable and even in tab-order.This would also follow the current UI-Events spec draft:
-- https://w3c.github.io/uievents/#event-type-keydown
Pre-merge Tasks
cypress-documentationbeen submitted to document any user-facing changes?[ ] Have the type definitions been updated with any user-facing API changes?[ ] Has the cypress.schema.json been updated with any new configuration options?