accept options.ensure to disable actionability checks
#4881
Conversation
|
What do you think of calling this option |
|
I like |
|
another question is whether we want this exposed in our command options API, similar to how users can do If we do want to expose this in options API, we should probably do so in a similar verbiage to |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
I think this should go in. This does not affect end-user API and only changes one command file |
| @@ -153,6 +153,14 @@ describe "src/cy/commands/actions/focus", -> | |||
| cy.get("[data-cy=rect]").focus().then -> | |||
| expect(onFocus).to.be.calledOnce | |||
|
|
|||
| it "can focus on readonly inputs", -> | |||
There was a problem hiding this comment.
Because this is the test that is effectively testing this entire PR - it needs a link above the issue to the issue that it's fixing.
) * accept ensure option on actionability * remove left-in code * update type_spec for changed error message * remove unneeded code, allow focused to be validated for readonly * address TODO in type.coffee about scrolling before typing into already focused * rename ensureReceiveablility -> ensureNotDisabled, revert error message
fix #4874
tasks
Pre-merge Tasks