fix: Handle privileged commands arg mutation #27282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 flaky tests on run #48883 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws waiting for the 3rd response |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
project-setup.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| ... > shows the configuration setup page when selecting e2e tests |
Output
Screenshots
Video
|
|
The first 5 flaky specs are shown, see all 25 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mjhenkes
approved these changes
Jul 13, 2023
AtofStryker
approved these changes
Jul 17, 2023
…com:cypress-io/cypress into issue-27200-privileged-command-arg-mutation
ryanthemanuel
pushed a commit
that referenced
this pull request
Jul 19, 2023
Co-authored-by: Stokes Player <stokes@cypress.io> Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com> Co-authored-by: Jordan <jordan@jpdesigning.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Matt Henkes <mjhenkes@gmail.com> Co-authored-by: Chris Breiding <chrisbreiding@gmail.com> fix: Fix web worker creation within spec frame (#27313) fix: Handle privileged commands arg mutation (#27282) fix(webpack-dev-server): add typeRoots to generated tsconfig for angular (#27117) fix memory import (#27324)
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The argument comparison would fail for privileged commands if any argument was mutated between invocation and running the command. The fix is to send the hashed arguments from when it's originally invoked for comparison in the server.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?