Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Angular 16.1 #27106

Merged
merged 5 commits into from
Jun 21, 2023
Merged

feat: support Angular 16.1 #27106

merged 5 commits into from
Jun 21, 2023

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Jun 21, 2023

Additional details

In Angular 16.1, some internal files' locations consumed by the Cypress Angular handler changed. This causes Cypress to error with:

Your configFile threw an error from: cypress.config.ts

We stopped running your tests because your config file crashed.

Error: Could not resolve "@angular-devkit/build-angular/src/webpack/configs/common.js". Do you have "@angular-devkit/build-angular" and "@angular-devkit/core" installed?
...

For reference, this is the commit in the Angular CLI where the change was made: angular/angular-cli@466d86d

Steps to test

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Jun 21, 2023

29 flaky tests on run #48018 ↗︎

0 27882 1348 0 Flakiness 29

Details:

Merge branch 'feat/angular-16.1-support' of https://github.com/leosvelperez/cypr...
Project: cypress Commit: ddca005c91
Status: Passed Duration: 22:22 💡
Started: Jun 21, 2023 9:08 PM Ended: Jun 21, 2023 9:31 PM
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@lmiller1990 lmiller1990 changed the title Lmiller/angular fix feat: support Angular 16.1 Jun 21, 2023
@lmiller1990 lmiller1990 mentioned this pull request Jun 21, 2023
3 tasks
@lmiller1990
Copy link
Contributor Author

I remade a third party PR, so I cannot approve, but I approved the previous one (#27030) which I had to remake here. I will go ahead and merge.

@lmiller1990 lmiller1990 merged commit 0055214 into develop Jun 21, 2023
@lmiller1990 lmiller1990 deleted the lmiller/angular-fix branch June 21, 2023 23:44
@mike-plummer mike-plummer changed the title feat: support Angular 16.1 fix: support Angular 16.1 Jun 23, 2023
@lmiller1990
Copy link
Contributor Author

Hi friends, turns out we are doing a off cycle release, this will be live in a few days (Mon 26 / Tue 27).

@mike-plummer mike-plummer changed the title fix: support Angular 16.1 feat: support Angular 16.1 Jun 26, 2023
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 26, 2023

Released in 12.16.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.16.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress 12.4.0 does not work with @angular-devkit/build-angular 16.1.0
4 participants