chore: remove flaky tooltip Percy snapshots from DebugSpec #25919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 flaky tests on run #44325 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | ||
|---|---|---|
| ... > runs generated spec |
Screenshot
|
|
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
| Test | ||
|---|---|---|
| App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs |
Screenshot
|
|
cypress-in-cypress.cy.ts • 1 flaky test • app-e2e
| Test | ||
|---|---|---|
| Cypress in Cypress > scales the AUT correctly in e2e |
Screenshot
|
|
cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | ||
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Screenshot
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
|
There's unrelated Percy flake in the build 😭 |
lmiller1990
approved these changes
Feb 23, 2023
mike-plummer
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Failures button is disabled if spec is not found locally#25870Additional details
We have some tests in
DebugSpec.cy.tsxthat are taking Percy snapshots of tooltips. These end up being flaky with Percy - sometimes the tooltip is rendered and sometimes it isn't. I think that we should remove these. The tooltip content is just text, and we are already asserting that the tooltip is appearing on screen and that the text is correct.Some recent examples of these snapshots flaking:
https://percy.io/cypress-io/cypress/builds/25301083/changed/1411039263?browser=chrome&browser_ids=34&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=800&widths=450%2C800
https://percy.io/cypress-io/cypress/builds/25338162/changed/1412986341?browser=chrome&browser_ids=34&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=800&widths=450%2C800
https://percy.io/cypress-io/cypress/builds/25209495/changed/1406985567?browser=chrome&browser_ids=34&subcategories=unreviewed%2Cchanges_requested&viewLayout=side-by-side&viewMode=new&width=800&widths=450%2C800
Steps to test
Look at the Percy build and see which snapshots have been removed under the "Missing" filter
PR Tasks
cypress-documentation?type definitions?