-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for next 13 #24396
Conversation
Thanks for taking the time to open a PR!
|
Any way we can help? Is this can be prioritized? |
The check for React 18 has been removed recently, need to verify if our internal check needs to stick around. Might need it to support 13.0.0 (no longer needed in 13.0.1) |
Awesome! I just tested, and indeed, I can confirm that updating Next.js (v13.0.2), works! |
bc85b87
to
7968cd5
Compare
@ZachJW34 looks like everything was working fine with Next 13 except for the dependency version warning. So this PR is mainly just adding 13 in the versions list and adding a system test, right? |
@astone123 It wasn't working for Next.js v13.0.0, but v13.0.1 + didn't need any source code changes (other than the deps warning). Good to be safe, and the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code seems fine, one comment/question - I think we need to get CI under control, it's getting slower and slower, any chance to reduce the amount of projects?
If not, all good, let's keep it in mind for other PRs.
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Support Next.js v13
Additional details
Bring our current support for Next.js 11 + 12 to v13. No support for
turbopack
or React SC (yet).Steps to test
npx create-next-app@latest my-app
npm i -D cypress
yarn && yarn cypress:open
, choosemy-app
pages/index.cy.tsx
and run itHow has the user experience changed?
Screen.Recording.2022-10-26.at.4.51.29.PM.mov
PR Tasks
cypress-documentation
?type definitions
?