-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE #23194
feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE #23194
Conversation
Thanks for taking the time to open a PR!
|
Looks good to me; I merged in develop to kick off a CI build. |
There was a linting issue, fixed that and force-pushed it. |
…NLOAD_PATH_TEMPLATE
Not sure if I need to do something more here? Seems to be some tests failing but I dont see how they are related to my patch. |
…NLOAD_PATH_TEMPLATE
Yeah, sorry about that - we have some flake in our tests that we're currently attempting to address. I'll see about getting this merged today, thank you for your patience! |
…NLOAD_PATH_TEMPLATE
Install cypress binary from China Mirror CYPRESS_DOWNLOAD_PATH_TEMPLATE='https://cdn.npmmirror.com/binaries/cypress/${version}/${platform}-${arch}/cypress.zip' npm install cypress |
User facing changelog
Including
version
as a variable that can be used inCYPRESS_DOWNLOAD_PATH_TEMPLATE
.Additional details
To allow users that are behind a firewall to point
CYPRESS_DOWNLOAD_PATH_TEMPLATE
at an internally hosted binary.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
? feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE cypress-documentation#4651type definitions
?