Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE #23194

Merged
merged 4 commits into from
Aug 16, 2022
Merged

feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE #23194

merged 4 commits into from
Aug 16, 2022

Conversation

tomasbjerre
Copy link
Contributor

User facing changelog

Including version as a variable that can be used in CYPRESS_DOWNLOAD_PATH_TEMPLATE.

Additional details

To allow users that are behind a firewall to point CYPRESS_DOWNLOAD_PATH_TEMPLATE at an internally hosted binary.

Steps to test

How has the user experience changed?

PR Tasks

@tomasbjerre tomasbjerre requested a review from a team as a code owner August 8, 2022 14:11
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 8, 2022

Thanks for taking the time to open a PR!

@BlueWinds
Copy link
Contributor

Looks good to me; I merged in develop to kick off a CI build.

@cypress
Copy link

cypress bot commented Aug 8, 2022



Test summary

37845 1 469 0Flakiness 7


Run details

Project cypress
Status Failed
Commit 6358a85
Started Aug 8, 2022 5:56 PM
Ended Aug 8, 2022 6:16 PM
Duration 19:48 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/e2e/origin/commands/assertions.cy.ts Failed
1 cy.origin assertions > #consoleProps > .should() and .and()

Flakiness

commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
2 ... > intercept log has consoleProps with intercept info
3 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tomasbjerre
Copy link
Contributor Author

There was a linting issue, fixed that and force-pushed it.

@tomasbjerre
Copy link
Contributor Author

Not sure if I need to do something more here? Seems to be some tests failing but I dont see how they are related to my patch.

@BlueWinds
Copy link
Contributor

Not sure if I need to do something more here? Seems to be some tests failing but I dont see how they are related to my patch.

Yeah, sorry about that - we have some flake in our tests that we're currently attempting to address. I'll see about getting this merged today, thank you for your patience!

@emilyrohrbough emilyrohrbough changed the title feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE (refs #5141 #16976 #22864) feat: including version in CYPRESS_DOWNLOAD_PATH_TEMPLATE Aug 15, 2022
@fengmk2
Copy link

fengmk2 commented Nov 6, 2022

Install cypress binary from China Mirror

CYPRESS_DOWNLOAD_PATH_TEMPLATE='https://cdn.npmmirror.com/binaries/cypress/${version}/${platform}-${arch}/cypress.zip' npm install cypress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CYPRESS_DOWNLOAD_MIRROR to be used with a static file server
4 participants