Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add template support, teardown & standalone #23117

Merged
merged 5 commits into from
Aug 8, 2022
Merged

Conversation

jordanpowell88
Copy link
Contributor

@jordanpowell88 jordanpowell88 commented Aug 4, 2022

User facing changelog

Adds Angular Component Testing Support
Adds Angular Template Support
Adds Support for Angular Standalone Components
Fixes bug where previous component was not torn down before remounting the next component

Steps to test

You can run system tests for angular-13 & angular-14 & component_testing_spec.ts

How has the user experience changed?

project-setup-angular c21fe57

PR Tasks

ZachJW34 and others added 2 commits August 2, 2022 17:42
Co-authored-by: Jordan <jordan@jpdesigning.com>
Co-authored-by: Zachary Williams <zachjw34@gmail.com>
@jordanpowell88 jordanpowell88 requested review from a team as code owners August 4, 2022 19:13
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 4, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 4, 2022



Test summary

37835 0 456 0Flakiness 10


Run details

Project cypress
Status Passed
Commit bf83bc5
Started Aug 5, 2022 1:07 PM
Ended Aug 5, 2022 1:27 PM
Duration 20:12 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs response
4 ... > logs request + response headers
5 ... > logs Method, Status, URL, and XHR
This comment includes only the first 5 flaky tests. See all 10 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jordanpowell88 jordanpowell88 changed the title feat: add Angular component testing support feat: add template support, teardown & standalone Aug 4, 2022
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, just a question but code seems fine 💯 nice tests!

npm/angular/src/mount.ts Show resolved Hide resolved
npm/angular/src/mount.ts Outdated Show resolved Hide resolved
npm/angular/src/mount.ts Show resolved Hide resolved
@@ -5,7 +5,7 @@
"main": "dist/index.js",
"scripts": {
"prebuild": "rimraf dist",
"build": "tsc || echo 'built, with type errors'",
"build": "rollup -c rollup.config.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired with Jordan on this, we fixed the Angular cleanup and needed to add @cypress/mount-utils for the cleanup. We needed to revert back to rollup so that the @cypress/mount-utils was internalized.

system-tests/project-fixtures/angular/src/app/mount.cy.ts Outdated Show resolved Hide resolved
@ZachJW34 ZachJW34 mentioned this pull request Aug 5, 2022
@lmiller1990 lmiller1990 self-requested a review August 8, 2022 00:18
tsconfigOverride: {
compilerOptions: {
declaration: true,
target: 'es6', // not sure what this should be?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we still unsure about this? What additional investigation is needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked into it, es5 or es6 is probably fine, we should update this - and also use a single common file for rollup config.

Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small question but otherwise looks good. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular CT Support
4 participants