-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add template support, teardown & standalone #23117
Conversation
Co-authored-by: Jordan <jordan@jpdesigning.com>
Co-authored-by: Zachary Williams <zachjw34@gmail.com>
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, just a question but code seems fine 💯 nice tests!
@@ -5,7 +5,7 @@ | |||
"main": "dist/index.js", | |||
"scripts": { | |||
"prebuild": "rimraf dist", | |||
"build": "tsc || echo 'built, with type errors'", | |||
"build": "rollup -c rollup.config.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paired with Jordan on this, we fixed the Angular cleanup and needed to add @cypress/mount-utils
for the cleanup. We needed to revert back to rollup so that the @cypress/mount-utils
was internalized.
tsconfigOverride: { | ||
compilerOptions: { | ||
declaration: true, | ||
target: 'es6', // not sure what this should be? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still unsure about this? What additional investigation is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked into it, es5
or es6
is probably fine, we should update this - and also use a single common file for rollup
config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a small question but otherwise looks good. Nice work!
User facing changelog
Adds Angular Component Testing Support
Adds Angular Template Support
Adds Support for Angular Standalone Components
Fixes bug where previous component was not torn down before remounting the next component
Steps to test
You can run system tests for
angular-13
&angular-14
&component_testing_spec.ts
How has the user experience changed?
PR Tasks
cypress-documentation
? docs(guides): add angular component testing documentation cypress-documentation#4624type definitions
?