Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove flaky click from navigation spec #21466

Merged
merged 2 commits into from
May 13, 2022

Conversation

marktnoonan
Copy link
Contributor

@marktnoonan marktnoonan commented May 13, 2022

User facing changelog

No changes.

Additional details

The flaky test is checking that the mutation to store the width of the InlineSpecsList is called with a specific width value.

To check the value, the test expects at a certain position of the right hand edge of the reporter, the reporter takes up the full space between the nav and the AUT.

Previously, it used to click the "toggle specs list" button to close the specs list, before doing the test. Now that the specs list is closed by default, this test is in the weird situation of only passing when that click flakes, which is a known issue (see comment here), we often use { force: true } elsewhere when clicking that button in an e2e test.

This PR removes the click since it is no longer needed.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 13, 2022

Thanks for taking the time to open a PR!

@marktnoonan marktnoonan requested a review from lmiller1990 May 13, 2022 13:02
@marktnoonan marktnoonan marked this pull request as ready for review May 13, 2022 13:03
@cypress
Copy link

cypress bot commented May 13, 2022



Test summary

9287 2 109 0Flakiness 7


Run details

Project cypress
Status Failed
Commit 2915eef
Started May 13, 2022 3:18 PM
Ended May 13, 2022 3:41 PM
Duration 23:13 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

Run group: 5x-driver-electron (Linux, Electron )
cypress/e2e/cypress/proxy-logging.cy.ts Failed
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first
Run group: 5x-driver-electron-experimentalSessionAndOrigin (Linux, Electron )
cypress/e2e/cypress/proxy-logging.cy.ts Failed
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged first

Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
commands/actions/selectFile.cy.js Flakiness
1 ... > selects files with a hidden input from a visible label
e2e/origin/commands/screenshot.cy.ts Flakiness
1 cy.origin screenshot > #consoleProps > .screenshot()
e2e/origin/commands/cookies.cy.ts Flakiness
1 cy.origin cookies > #consoleProps > .getCookie()
e2e/origin/commands/waiting.cy.ts Flakiness
1 cy.origin waiting > #consoleProps > .wait()
This comment includes only the first 5 flaky tests. See all 7 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@marktnoonan marktnoonan merged commit d45c9f8 into 10.0-release May 13, 2022
@marktnoonan marktnoonan deleted the marktnoonan/flaky-nav-test branch May 13, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants