fix: remove nullish coalescing in js files to support node 12 #20094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Remove nullish coalescing operator in js files
Additional details
plugins/react-scripts
was failing on Node v12 due to the??
operator. It's fine in typescript files since we transpile them, but not in javascript files.How has the user experience changed?
@cypress/react/plugins/react-scripts
works with node v12Testing
I tested this by checkout out cypress-component-testing-examples and testing against
create-react-app
using nvm to switch to node v12. Runningnpx cypress open-ct
throws:Then, run
yarn workspace @cypress/react build
and copy and paste thenpm/react/plugins
andnpm/react/dist
folders into~/<path-to-repo>/cypress-component-testing-examples/create-react-app/node_modules/@cypress/react
and runnpx cypress open-ct
. No failure!PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?