Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redesign server errors #20072

Merged
merged 172 commits into from
Feb 11, 2022
Merged
Changes from 1 commit
Commits
Show all changes
172 commits
Select commit Hold shift + click to select a range
912369f
chore: rename errors.js -> errors.ts
tgriesser Jan 28, 2022
3114807
refactor: type safety on errors
tgriesser Jan 28, 2022
d9f4baf
refactor: add err_template for consistent error formatting
tgriesser Jan 28, 2022
e0880a0
fix a few system tests
tgriesser Jan 31, 2022
dc99313
fix tests; update snapshots
brian-mann Jan 31, 2022
c80f226
Fix types
tgriesser Jan 31, 2022
45e2221
normalize snapshot - remove chalk ansi colors
brian-mann Jan 31, 2022
af2e9aa
Merge branch 'tgriesser/chore/refactor-errors' of https://github.com/…
brian-mann Jan 31, 2022
3ebe6f7
more unit test fixes
brian-mann Jan 31, 2022
74619e3
more system test fixes
brian-mann Jan 31, 2022
2faecf5
circleci build
brian-mann Jan 31, 2022
8322e07
backtick always in stdout, fix error formatting and failing snapshots
brian-mann Jan 31, 2022
69d7fd6
Merge branch 'develop' into tgriesser/chore/refactor-errors
tgriesser Feb 1, 2022
32f3e18
refactor: create @packages/errors
tgriesser Feb 2, 2022
931482d
fix import
tgriesser Feb 2, 2022
3c7483e
fix import
tgriesser Feb 2, 2022
55499d1
fixing build / tests
tgriesser Feb 2, 2022
b63865c
remove extraneous file
tgriesser Feb 2, 2022
8d2c963
move warnIfExplicitCiBuildId
tgriesser Feb 2, 2022
5041e05
fix build / tests
tgriesser Feb 2, 2022
06b73b8
Fix
tgriesser Feb 2, 2022
3fd2043
error, type fixes, documentation, standardize child process error ser…
tgriesser Feb 2, 2022
00e479a
fix import
tgriesser Feb 2, 2022
1dc7621
build errors on install
tgriesser Feb 2, 2022
6714aad
wrote specs generating visual images of all errors
brian-mann Feb 3, 2022
d2b2f8d
remove unused dep
brian-mann Feb 3, 2022
7badd37
sanitize stack traces
brian-mann Feb 3, 2022
9ff1ca4
add image diffing
brian-mann Feb 3, 2022
1482206
remove Courier New + MesloLGS NF font
brian-mann Feb 3, 2022
a75689b
type fixes, remove Bluebird, general cleanup
tgriesser Feb 3, 2022
09d5c86
TS Cleanup
tgriesser Feb 3, 2022
7f7a1ae
skip typecheck on tests for now
tgriesser Feb 3, 2022
ed39d17
yarn.lock
tgriesser Feb 3, 2022
a097955
fix @types/chai version
tgriesser Feb 3, 2022
73e88bc
fix yarn.lock
tgriesser Feb 3, 2022
7aa1f87
Different version of mocha types so it isnt patched
tgriesser Feb 3, 2022
f35a3e6
errors spec snapshot
brian-mann Feb 3, 2022
bc1823a
CI fix
tgriesser Feb 4, 2022
5fb95a2
fixes
tgriesser Feb 4, 2022
2a849ff
store snapshot images in circle artifacts
brian-mann Feb 4, 2022
98e47bb
dont change artifact destination prefix
brian-mann Feb 4, 2022
f713ef5
use Courier Prime
brian-mann Feb 4, 2022
557ab5c
antialias the text
brian-mann Feb 4, 2022
baf6430
decrease pixelmatch threshold, fail in CI only when changed pixels > 100
brian-mann Feb 4, 2022
f11bc28
increase timeout
brian-mann Feb 4, 2022
8d77745
overflow: hidden, remove new Promise, add debug logging
brian-mann Feb 5, 2022
d3efd64
run unit tests w/ concurrency=1
tgriesser Feb 4, 2022
672bf82
unique window per file
tgriesser Feb 4, 2022
61f1699
disable app hardware acceleration + use in process gpu + single process
brian-mann Feb 4, 2022
86a6192
do not do image diffing
brian-mann Feb 4, 2022
011e2aa
store snapshot html
brian-mann Feb 4, 2022
c6232c6
Merge branch 'tgriesser/chore/refactor-errors' of https://github.com/…
brian-mann Feb 4, 2022
831f2d9
remove concurrency
brian-mann Feb 4, 2022
17f1ce6
fix assertion
brian-mann Feb 4, 2022
d8c8446
fixing ci
tgriesser Feb 4, 2022
b95c2a3
Link in readme
tgriesser Feb 4, 2022
8935f18
pass the browsers to listItems
tgriesser Feb 4, 2022
7e9468d
fix: build @packages/errors in CI, defer import to prevent errors loc…
tgriesser Feb 4, 2022
9995f25
Merge branch 'develop' into tgriesser/chore/refactor-errors
tgriesser Feb 4, 2022
fddc4f0
fix run-if-ci.sh
tgriesser Feb 4, 2022
149001a
Merge branch 'develop' into tgriesser/chore/refactor-errors
brian-mann Feb 5, 2022
b444007
remove dead code
brian-mann Feb 5, 2022
6df0f20
Mark the .html files as generated in gitattributes
tgriesser Feb 5, 2022
5f4bdf5
fix running single error case, slice out more of the brittle stack
brian-mann Feb 5, 2022
0d4f1ec
remove additional brittle stack line
brian-mann Feb 5, 2022
f99fb05
firefox web security error
brian-mann Feb 5, 2022
e53647c
nest inside of describe
brian-mann Feb 5, 2022
e62d1a9
reformat and redesign errors
brian-mann Feb 6, 2022
a1deba7
more error cleanup and standardization
brian-mann Feb 7, 2022
941ac21
additional formatting of errors, code cleanup, refactoring
brian-mann Feb 7, 2022
f6a00c0
update ansi colors to match terminal colors
brian-mann Feb 7, 2022
9da5e6f
cleanup remaining loose ends, update several errors, compact excess f…
brian-mann Feb 7, 2022
58173e2
fix types
brian-mann Feb 7, 2022
f6caadf
additional formatting, remove TODO's, ensure no [object Object] in ou…
brian-mann Feb 7, 2022
490b524
add test for 412 server response on invalid schema
brian-mann Feb 7, 2022
53d7360
update unknown dashboard error on creating run
brian-mann Feb 7, 2022
80be4b5
use fs.access instead of fs.stat for perf
brian-mann Feb 7, 2022
9ba362c
added PLUGINS_FILE_NOT_FOUND error
brian-mann Feb 7, 2022
e9c926a
add plugins system test around plugins synchronously throwing on require
brian-mann Feb 7, 2022
63231c7
remove forcing process.cwd() to be packages/server, update affected code
brian-mann Feb 7, 2022
978ce03
perf: lazy load chalk
brian-mann Feb 7, 2022
e454600
remove excessive line since the file exists but is invalid
brian-mann Feb 7, 2022
4cbbab2
fix types
brian-mann Feb 7, 2022
983f969
add system test when plugins function throws a synchronous error
brian-mann Feb 7, 2022
a3dc456
create new PLUGINS_INVALID_EVENT_ERROR, wire it up correctly for erro…
brian-mann Feb 7, 2022
b67edb9
only show a single stack trace, either originalError or internal cypr…
brian-mann Feb 7, 2022
a5ef964
push error html snapshots
brian-mann Feb 7, 2022
bab19ee
fix tests, types
brian-mann Feb 7, 2022
75929ae
fix test
brian-mann Feb 7, 2022
d48d3f9
fix failing tests
brian-mann Feb 7, 2022
f9b474f
fix tests
brian-mann Feb 7, 2022
f7e7c30
fixes lots of broken tests
brian-mann Feb 7, 2022
a3ee5ac
more test fixes
brian-mann Feb 7, 2022
d580755
fixes more tests
brian-mann Feb 7, 2022
38c3e83
fix type checking
brian-mann Feb 7, 2022
e600767
wip: consistent handling of interpolated values
tgriesser Feb 7, 2022
fa82f2d
feat: fixing up errors, added simple error comparison tool
tgriesser Feb 8, 2022
1a2dbef
wrapping up error formatting
tgriesser Feb 8, 2022
e808c7e
Fixes for unit tests
tgriesser Feb 8, 2022
b08dfd8
fix PLUGINS_VALIDATION_ERROR
tgriesser Feb 8, 2022
91641ea
fix fs.readdir bug, show rows even if there's only markdown formattin…
brian-mann Feb 8, 2022
d82e8cb
when in base-list, show full width of errors
brian-mann Feb 8, 2022
49d739e
Fix type errors
tgriesser Feb 8, 2022
bba9685
added searching and filtering for files based on error name
brian-mann Feb 8, 2022
fae706d
Merge branch 'feat/redesign-errors' of https://github.com/cypress-io/…
brian-mann Feb 8, 2022
9f6a43c
fix: system tests
tgriesser Feb 8, 2022
39036ad
updated NO_SPECS_FOUND error to properly join searched folder + pattern
brian-mann Feb 8, 2022
5ad25e6
Merge branch 'feat/redesign-errors' of https://github.com/cypress-io/…
brian-mann Feb 8, 2022
0360bc9
fixes failing tests
brian-mann Feb 9, 2022
ea6b2d5
fix test
brian-mann Feb 9, 2022
95f2213
preserve original spec pattern, display relative to projectRoot for t…
brian-mann Feb 9, 2022
e068176
make the nodeVersion path display in gray, not white
brian-mann Feb 9, 2022
45c1a73
fix tests, pass right variables
brian-mann Feb 9, 2022
1062106
fix chrome:canary snapshots
brian-mann Feb 9, 2022
2470ec4
update snapshots
brian-mann Feb 9, 2022
307c522
update snapshot
brian-mann Feb 9, 2022
6f0edc1
strip newlines caused by "Still waiting to connect to {browser}..."
brian-mann Feb 9, 2022
de68a21
don't remove the snapshotHtmlFolder in CI, add additional verificatio…
brian-mann Feb 9, 2022
2ef825f
update snapshot
brian-mann Feb 9, 2022
9659bdb
update snapshot
brian-mann Feb 9, 2022
a343e66
update snapshot
brian-mann Feb 9, 2022
2e8e088
update snapshot
brian-mann Feb 9, 2022
6f89d9d
update snapshot
brian-mann Feb 9, 2022
b527e74
update snapshot
brian-mann Feb 9, 2022
f65972e
update gitignore
brian-mann Feb 9, 2022
a3aadba
fix snapshot
brian-mann Feb 9, 2022
1969854
update snapshot html
brian-mann Feb 9, 2022
6636722
update logic for parsing the resolve pattern matching, add tests
brian-mann Feb 9, 2022
19acbb4
update snapshots
brian-mann Feb 9, 2022
60731a6
update snapshot
brian-mann Feb 9, 2022
f1394d8
update snapshot
brian-mann Feb 9, 2022
5089800
update snapshot
brian-mann Feb 9, 2022
7179ccd
fix failing test
brian-mann Feb 9, 2022
23181e7
fix: error_message_spec
tgriesser Feb 9, 2022
fd35999
fix snapshot
tgriesser Feb 9, 2022
6a0e00b
run each variant through an it(...) so multiple failures are received
brian-mann Feb 9, 2022
cd76bcf
add newlines to multiline formatters, add fmt.stringify, allow format…
brian-mann Feb 9, 2022
b32e91f
stringify invalid return values from plugins
brian-mann Feb 9, 2022
af1baf6
move config validation errors into packages/errors, properly highligh…
brian-mann Feb 9, 2022
16e19f3
add component testing yarn commands
brian-mann Feb 9, 2022
0bb1ea9
fix the arrow not showing on details
brian-mann Feb 9, 2022
6091353
fix typescript error
brian-mann Feb 9, 2022
05a3917
fixed lots of poorly written tests that weren't actually testing anyt…
brian-mann Feb 9, 2022
3ecde09
fixes tests
brian-mann Feb 9, 2022
11f47b2
fixes tests, adds new error template for validating within an array l…
brian-mann Feb 10, 2022
114dd02
remove dupe line
brian-mann Feb 10, 2022
3268eab
fix copy for consistency, update snapshots
brian-mann Feb 10, 2022
7d4292b
remove redundant errors, standardize formatting and phrasing
brian-mann Feb 10, 2022
b748c1f
more formatting
brian-mann Feb 10, 2022
04a9389
remove excess snapshots
brian-mann Feb 10, 2022
05f9103
prune out excessive error snapshot html files when not in CI
brian-mann Feb 10, 2022
3f47bd6
add missing tests, add case for when config validation fails without …
brian-mann Feb 10, 2022
2307e44
fixes test
brian-mann Feb 10, 2022
23241f5
update snapshot
brian-mann Feb 10, 2022
ed274fa
update snapshot
brian-mann Feb 10, 2022
95d6856
update snapshot
brian-mann Feb 10, 2022
3fed188
sort uniqErrors + errorKeys prior to assertion - assert one by one
brian-mann Feb 10, 2022
703d976
add system test for binding to an event with the wrong handler
brian-mann Feb 10, 2022
6e484a5
fixes tests
brian-mann Feb 10, 2022
42316ae
set more descriptive errors when setting invalid plugin events, or du…
brian-mann Feb 10, 2022
84cb7e2
remove duplicate PLUGINS_EVENT_ERROR, collapse into existing error
brian-mann Feb 10, 2022
01f3d5e
use the same multiline formatting as @packages/errors
brian-mann Feb 10, 2022
c10421e
standardize verbiage and highlighting for consistency
brian-mann Feb 10, 2022
ef463e0
fix incorrect error path
brian-mann Feb 10, 2022
293afe5
fixes tests, standardized and condensed more language
brian-mann Feb 11, 2022
ac14cce
Update packages/errors/src/errors.ts
brian-mann Feb 11, 2022
45d2682
Update guides/error-handling.md
brian-mann Feb 11, 2022
6507133
Update guides/error-handling.md
brian-mann Feb 11, 2022
58a74a3
added some final todo's
brian-mann Feb 11, 2022
4896c73
Merge branch 'feat/redesign-errors' of https://github.com/cypress-io/…
brian-mann Feb 11, 2022
6dec56b
Merge branch 'develop' into feat/redesign-errors
brian-mann Feb 11, 2022
879d30c
fix types
brian-mann Feb 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update snapshot
brian-mann committed Feb 10, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 23241f51e102769bf9cc24eddcf1b1dc3a6dbe15
1 change: 1 addition & 0 deletions system-tests/__snapshots__/record_spec.js
Original file line number Diff line number Diff line change
@@ -1450,6 +1450,7 @@ exports['e2e record api interaction warnings create run warnings unknown warning
Warning from Cypress Dashboard: You are almost out of time
Details:
{
"code": "OUT_OF_TIME",
"name": "OutOfTime",