build(angular): update angular to version 12 #20042

jordanpowell88 · 2022-02-03T19:46:38Z

User facing changelog

Updated Angular version from 11 to 12

Additional details

We are currently unable to serve the current Angular app because the Typescript 4.2.4 is not supported in Angular version 11.

How has the user experience changed?

This should not effect the user experience as Angular CT has not been deployed yet

PR Tasks

[na] Have tests been added/updated?
[na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?
[na] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2022-02-03T19:46:40Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

cypress · 2022-02-03T20:00:39Z

Test summary

19167 • 6 • 218 • 0 • 9

Run details


Project	cypress
Status	Failed
Commit	`16a7cd7`
Started	Feb 10, 2022 4:24 PM
Ended	Feb 10, 2022 4:36 PM
Duration	11:44 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

Failures

Run group: 5x-driver-firefox (Linux, Firefox )
	cypress/integration/e2e/e2e_cookies_spec.js	1
1	e2e cookies spec > __Host- prefix > errors when __Host- cookie and path
Run group: 5x-driver-chrome (Linux, Chrome )
	cypress/integration/e2e/e2e_cookies_spec.js	2
1	e2e cookies spec > __Host- prefix > errors when __Host- cookie and secure:false
2	e2e cookies spec > __Secure- prefix > errors when __Secure- cookie secure:false
Run group: 5x-driver-chrome:beta (Linux, Chrome beta )
	cypress/integration/e2e/e2e_cookies_spec.js	3
1	e2e cookies spec > __Host- prefix > can set __Host- cookie
2	e2e cookies spec > __Host- prefix > errors when __Host- cookie and secure:false
3	e2e cookies spec > __Secure- prefix > can set __Secure- cookie

Flakiness

	cypress/integration/e2e/e2e_cookies_spec.js		5
1	e2e cookies spec > __Secure- prefix > errors when __Secure- cookie secure:false
2	e2e cookies spec > __Host- prefix > can set __Host- cookie
3	e2e cookies spec > __Secure- prefix > can set __Secure- cookie
4	e2e cookies spec > __Host- prefix > can set __Host- cookie
5	e2e cookies spec > __Secure- prefix > errors when __Secure- cookie secure:false
This comment includes only the first 5 flaky tests. See all 9 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

jordanpowell88 · 2022-02-04T18:39:56Z

npm/angular/src/app/material-button/material-button.component.ts

@@ -1,5 +1,4 @@
 import { Component, OnInit } from '@angular/core'
-import '@angular/material/prebuilt-themes/indigo-pink.css'


This import does not work this way in Angular. And was throwing a linting error

admah

LGTM 🚀

…t in angular 12

jordanpowell88 · 2022-02-10T16:08:36Z

npm/angular/cypress/plugins/cy-ts-preprocessor.ts

@@ -1,134 +0,0 @@
-const wp = require('@cypress/webpack-preprocessor')


I'm not sure why this file is in here as I don't see it being used anywhere

jordanpowell88 · 2022-02-10T16:10:53Z

npm/angular/cypress/plugins/webpack.config.ts

 import * as path from 'path'
+import { AngularWebpackPlugin } from '@ngtools/webpack'


We need a way to use Webpack 5 now after updating to Angular v 12. This plugin has over 2 million weekly downloads and is essentially built to be an "Webpack 5.x plugin for the Angular Ahead-of-Time compiler"

It sounds like this will be a blocker for merging, right? What's the urgency like for Angular 12.x support?

Yeah I am actively working on this locally. Once I find a solution locally, I will attempt to add these changes here. I will say that when we release Angular CT we need to support the most recent version of Angular which is actually 13. There is a large number of Angular users who use the most recent versions. Currently we are unable to upgrade this app here to 13 though as Angular requires a minimum Node version of 16.10 and we are using 16.5. My plan was to get to 12 and then create a separate PR to get to 13 because of that

Okay, great. Do you mind setting this to draft until it's read for a re-review?

jordanpowell88 added 4 commits February 3, 2022 14:37

build(angular): update @angular/cli from 11 => 12

9e9d9c9

build(angular): update @angular/core from 11 => 12

d48ee03

build(angular): update @angular/cdk from 11 => 12

8ef717b

build(angular): update @angular/material from 11 => 12

cab31bd

jordanpowell88 changed the base branch from develop to master February 3, 2022 19:46

jordanpowell88 self-assigned this Feb 3, 2022

jordanpowell88 added the npm: @cypress/angular @cypress/angular package issues label Feb 3, 2022

jordanpowell88 requested review from lmiller1990 and admah February 3, 2022 19:47

build(angular): update tsconfig after updating

9573e6c

jordanpowell88 force-pushed the update-angular-to-12 branch from 53d37be to 9573e6c Compare February 4, 2022 18:38

jordanpowell88 commented Feb 4, 2022

View reviewed changes

admah previously approved these changes Feb 4, 2022

View reviewed changes

build(angular): update webpack config to support webpack 5 the defaul…

acd944d

…t in angular 12

jordanpowell88 dismissed admah’s stale review via acd944d February 7, 2022 21:40

jordanpowell88 changed the title ~~build(angular): Update angular to version 12~~ build(angular): update angular to version 12 Feb 10, 2022

jordanpowell88 commented Feb 10, 2022

View reviewed changes

build: update tsconfig and webpack config

16a7cd7

jordanpowell88 marked this pull request as draft February 17, 2022 14:22

lmiller1990 removed their request for review March 28, 2022 02:23

lmiller1990 mentioned this pull request Apr 11, 2022

Component Testing on Angular components #15903

Closed

jordanpowell88 closed this May 10, 2022

jordanpowell88 deleted the update-angular-to-12 branch May 10, 2022 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(angular): update angular to version 12 #20042

build(angular): update angular to version 12 #20042

jordanpowell88 commented Feb 3, 2022

cypress-bot bot commented Feb 3, 2022

cypress bot commented Feb 3, 2022 •

edited

Loading

jordanpowell88 Feb 4, 2022

admah left a comment

jordanpowell88 Feb 10, 2022

jordanpowell88 Feb 10, 2022

lmiller1990 Feb 16, 2022

jordanpowell88 Feb 16, 2022

lmiller1990 Feb 17, 2022

		@@ -1,5 +1,4 @@
		import { Component, OnInit } from '@angular/core'
		import '@angular/material/prebuilt-themes/indigo-pink.css'

		@@ -1,134 +0,0 @@
		const wp = require('@cypress/webpack-preprocessor')

		import * as path from 'path'
		import { AngularWebpackPlugin } from '@ngtools/webpack'

build(angular): update angular to version 12 #20042

build(angular): update angular to version 12 #20042

Conversation

jordanpowell88 commented Feb 3, 2022

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

cypress-bot bot commented Feb 3, 2022

cypress bot commented Feb 3, 2022 • edited Loading

Test summary

Run details

Failures

Flakiness

jordanpowell88 Feb 4, 2022

Choose a reason for hiding this comment

admah left a comment

Choose a reason for hiding this comment

jordanpowell88 Feb 10, 2022

Choose a reason for hiding this comment

jordanpowell88 Feb 10, 2022

Choose a reason for hiding this comment

lmiller1990 Feb 16, 2022

Choose a reason for hiding this comment

jordanpowell88 Feb 16, 2022

Choose a reason for hiding this comment

lmiller1990 Feb 17, 2022

Choose a reason for hiding this comment

cypress bot commented Feb 3, 2022 •

edited

Loading