fix(webpack-dev-server): remove hard dependency on html-webpack-plugin v4 #16108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
…o/cypress into remove-html-4-coupling
elevatebart
approved these changes
Apr 22, 2021
| @@ -92,7 +92,7 @@ | |||
| "@types/glob": "7.1.1", | |||
| "@types/lodash": "4.14.168", | |||
| "@types/markdown-it": "0.0.9", | |||
| "@types/mini-css-extract-plugin": "0.8.0", | |||
| "@types/mini-css-extract-plugin": "1.4.2", | |||
There was a problem hiding this comment.
Why isn't this 1.5.0 like the one is web-config?
There was a problem hiding this comment.
The latest types available are 1.4.2. 1.5.0 does not have types available.
|
@elevatebart we did, but then I realized this won't work for webpack 5 users. So we need to support a range of html-webpack-plugin that corresponds to the range of webpack version we support (4.x and 5.x). |
tgriesser
added a commit
that referenced
this pull request
Apr 26, 2021
* develop: (49 commits) fix: `cy.type()` should not change the value attr of button-like inputs. (#16154) fix: properly detect `cy.intercept(url, routeMatcher, handler)` overload (#16167) fix: consider multiple routes when looking for aliases (#16180) fix: pass contextIsolation: true (#16165) chore: fix failing "should handle aborted requests" test (#16170) feat(issue-3741): added keyboard support for folder (#15648) fix(webpack-dev-server): remove hard dependency on html-webpack-plugin v4 (#16108) chore(deps): downgrade electron to v12.0.0-beta.14 (#16113) fix: accept absolute paths in vite dev server (#16148) fix: cy.then shows wrong type when collection of HTMLElement's is provided (#15869) fix: do not treat utf8 requests as binary (#15946) chore: fix types docs: fix broken links for @cypress/react example recipes (#15674) update circle yml ignore undefined beforeEach fix: make vite-dev-server work on windows (#16103) chore: add triple slash reference chore: remove conflicting types chore: rebuild yarn lock resolve conflicts in master(fe0b63c) and develop ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Remove
html-webpack-plugin@4as a direct dependency for@cypress/webpack-dev-server.Additional details
Making
html-webpack-pluginapeerDependency, and allows versions 4 and 5. This means the user must install eitherhtml-webpack-plugin@4andwebpack@4orhtml-webpack-plugin@5andwebpack@5.I also removed some types that conflicted between webpack 4 and 5.
I added a nextjs webpack 5 example but cannot get it to run on CI. I tested manually. We have to specify a set version for
webpackandhtml-plugin-webpackin@cypress/webpack-dev-serverunderdevDependencies. What would be ideal is some way to conditionally change this depending on the which example project is running, but I couldn't find a good solution. I even triedcp examples/nextjs-webpack-5/node_modules/{webpack,html-plugin-webpack} ../../../webpack-dev-server/node_modules, but this messed things up royally on CI and is a hack.I think ideally the examples projects should somehow install
@cypress/webpack-dev-serverinto their ownnode_modulesdirectory instead of relying on traversing up to the local version. This would solve a lot of problems and make the test more "real world".For now I just left the nextjs example there with the goal of finding a good way to run it on CI in the future.
Nextjs specifically introduces complexity because they inline their webpack version - it's not installed in
node_modules, but compied and shipped as part of theirnext/serverpackage.How has the user experience changed?
You can bring your own webpack and html-webpack-plugin version. Must be 4 or 5.
Perhaps we can update the Cypress wizard in the future to account for
next.config.js, wherewebpack5: truecan be configured.PR Tasks