Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fix server integration test #15948

Merged
merged 6 commits into from
Apr 13, 2021

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Apr 12, 2021

User facing changelog

N/A - internal only

Additional details

Fixes a failing server integration test I introduced in #15787. I had dismissed it as flake, but it's a legitimately failing test.

PR Tasks

  • Have tests been added/updated?
  • N/A Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@chrisbreiding chrisbreiding requested a review from a team as a code owner April 12, 2021 20:35
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Apr 12, 2021



Test summary

9494 0 111 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 2ee686f
Started Apr 13, 2021 3:09 PM
Ended Apr 13, 2021 3:22 PM
Duration 12:49 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions
Copy link
Contributor

Internal Jira issue: TR-758

@chrisbreiding chrisbreiding requested a review from flotwig April 13, 2021 14:40
@chrisbreiding chrisbreiding merged commit 59cc69e into develop Apr 13, 2021
@chrisbreiding chrisbreiding deleted the fix-failing-integration-test branch April 5, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants