-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add dtslint and Cypress static types #1044
Merged
brian-mann
merged 6 commits into
cypress-io:develop
from
NicholasBoll:feat/add-cypress-typings
Dec 8, 2017
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ae550a8
chore: Add dtslint and Cypress static types
NicholasBoll bd60550
chore: Fix types location for cli build
NicholasBoll 4b0432b
chore: Removed api from api command paths
NicholasBoll f0b5310
chore: Remove semicolons from type definitions
NicholasBoll 13a201f
chore: Removed semicolons not caught by tslint
NicholasBoll 8f88970
chore: Add type tests
NicholasBoll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// Shim definition to export a namespace. Cypress is actually a global module | ||
// so import/export isn't allowed there. We import here and define a global module | ||
// so that Cypress can get and use the Blob type | ||
|
||
// tslint:disable-next-line:no-implicit-dependencies | ||
import * as blobUtil from 'blob-util' | ||
|
||
export = BlobUtil | ||
export as namespace BlobUtil | ||
|
||
declare namespace BlobUtil { | ||
type BlobUtilStatic = typeof blobUtil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// Shim definition to export a namespace. Cypress is actually a global module | ||
// so import/export isn't allowed there. We import here and define a global module | ||
// so that Cypress can get and use the Blob type | ||
import * as BluebirdStatic from 'bluebird' | ||
|
||
export = Bluebird | ||
export as namespace Bluebird | ||
|
||
declare namespace Bluebird { | ||
type BluebirdStatic = typeof BluebirdStatic | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure these have to be normal dependencies for downstream projects. I haven't actually deployed and linked as
devDependencies
, but from other testing the types will fail and fallback toany
if the types can't be found.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think they will have to be included then.