Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running headlessly, Electron reports the browser as out of focus #1939

Closed
brian-mann opened this issue Jun 13, 2018 · 1 comment · Fixed by #1962
Closed

When running headlessly, Electron reports the browser as out of focus #1939

brian-mann opened this issue Jun 13, 2018 · 1 comment · Fixed by #1962
Assignees
@brian-mann
Labels
type: bug type: unexpected behavior User expected result, but got another
Milestone
3.0.2

Comments

@brian-mann
Copy link
Member

This causes the browser not to fire its native focus and blur events, which then causes the driver to fallback to its own polyfill behaviors (which in essence can cause other issues).

It's always better for the browser to think it's in focus so that it natively fires all of its default events. All we have to do is call win.focusOnWebView() and even though the window is rendered offscreen, it will think it's correctly focused at all times.
@brian-mann brian-mann added type: bug type: unexpected behavior User expected result, but got another labels Jun 13, 2018
@brian-mann brian-mann added this to the 3.0.2 milestone Jun 13, 2018
@brian-mann brian-mann self-assigned this Jun 13, 2018
@brian-mann brian-mann mentioned this issue Jun 16, 2018
Merged
brian-mann added a commit that referenced this issue Jun 18, 2018
@brian-mann
fixes #1939, always focus on the electron webview
cc746d7
brian-mann added a commit that referenced this issue Jun 18, 2018
@brian-mann
WIP: fix focus / blur event handling (#1962)
7c6c8a2 
- fixes #1909 
- fixes #1939 
- fixes #1940
@brian-mann
Copy link
Member Author

Released in 3.0.2.

@kuceb kuceb mentioned this issue Jul 12, 2018
Closed
@brian-mann brian-mann mentioned this issue Jul 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-mann brian-mann

Labels
type: bug type: unexpected behavior User expected result, but got another
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

WIP: fix focus / blur event handling cypress-io/cypress
2 participants
@brian-mann @jennifer-shehane