Coerce TTY to true when using pipe'd child processes #1126
Comments
brian-mann
added a commit
that referenced
this issue
Dec 25, 2017
…r when xvfb exits with status code 1, force tty in linux, handle colors in windows, enable logging cypress:xvfb stderr * cli: fixes #838 start cypress in dev by routing through the CLI - matches how we run in production better to keep parity and consistency * cli: add coerceFalse for clarity * cli: add global flag, update to work with windows * server: bring into parity with root scripts * cli: just execute start script directly to work with windows * cli: if colors are supported then force them via env vars - this fixes windows not displaying colors from electron because by default isTTY is false (due to electron) * cli: fixes #921 don't ignore stderr, inherit stdio on everything except when linux + xvfb - filter out stderr messages coming from Xlib or libudev (from xvfb) * cli, server: force stderr tty so that normalize tty behavior when piping * server: drop in supports color so debug outputs more colors! * server: remove empty line * root: refer to cypress not monorepo * cli: make util.supportsColor return boolean * cl: add tests around spawn behavior with forcing colors, tty, and stdio configuration * cli: handle xvfb onStderrData callback to output debug information * cli: handle non zero exit code error from xvfb with special message
|
Fixed by #1120. |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per this repo: https://github.com/cypress-io/cypress-test-tty
And these CI providers: https://circleci.com/gh/cypress-io/cypress-test-tty and https://travis-ci.org/cypress-io/cypress-test-tty
Because we pipe the output of
stdoutandstderrwhen spawning the electron process from the CLI - this causesprocess.stdout.isTTYandtty.isatty(1)to befalse.Although this is technically true, since we are the ones controlling the piped process, we really want it to be have as a correctly "inherited" child process - which would then cause the checks for
ttyto betrue.This is important as terminal packages like
chalkormochadepend on this to figure out whether they should output colors, and additionally how to write things like new lines, etc.To fix this, we need to monkey patch the
isTTYproperty and overridetty.isattyto force these values to be true.The text was updated successfully, but these errors were encountered: