fix: ensure re-run of spec occurs when supportFile has change

.circleci/workflows.yml

@@ -28,7 +28,7 @@ mainBuildFilters: &mainBuildFilters
       only:
         - develop
         - /^release\/\d+\.\d+\.\d+$/
-        - 'ryanm/fix/v8-improvements'
+        - 'lmiller/issue-24874-css-updates'
 
 # usually we don't build Mac app - it takes a long time
 # but sometimes we want to really confirm we are doing the right thing
@@ -37,15 +37,15 @@ macWorkflowFilters: &darwin-workflow-filters
   when:
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
-    - equal: [ 'ryanm/fix/v8-improvements', << pipeline.git.branch >> ]
+    - equal: [ 'lmiller/issue-24874-css-updates', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
 linuxArm64WorkflowFilters: &linux-arm64-workflow-filters
   when:
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
-    - equal: [ 'ryanm/fix/v8-improvements', << pipeline.git.branch >> ]
+    - equal: [ 'lmiller/issue-24874-css-updates', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -63,7 +63,7 @@ windowsWorkflowFilters: &windows-workflow-filters
   when:
     or:
     - equal: [ develop, << pipeline.git.branch >> ]
-    - equal: [ 'ryanm/fix/v8-improvements', << pipeline.git.branch >> ]
+    - equal: [ 'lmiller/issue-24874-css-updates', << pipeline.git.branch >> ]
     - matches:
         pattern: /^release\/\d+\.\d+\.\d+$/
         value: << pipeline.git.branch >>
@@ -129,7 +129,7 @@ commands:
       - run:
           name: Check current branch to persist artifacts
           command: |
-            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "ryanm/fix/v8-improvements" ]]; then
+            if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "lmiller/issue-24874-css-updates" ]]; then
               echo "Not uploading artifacts or posting install comment for this branch."
               circleci-agent step halt
             fi

npm/vite-dev-server/cypress/e2e/vite-dev-server.cy.ts

@@ -76,6 +76,48 @@ describe('Config options', () => {
       expect(verifyFile).to.eq('OK')
     })
   })
+
+  it('supports HMR for css imported to supportFile', () => {
+    cy.scaffoldProject('vite3.0.2-react')
+    cy.openProject('vite3.0.2-react', ['--config-file', 'cypress-vite.config.ts'])
+    cy.startAppServer('component')
+
+    cy.visitApp()
+    cy.contains('App.cy.jsx').click()
+    cy.waitForSpecToFinish()
+    cy.get('.passed > .num').should('contain', 2)
+
+    cy.withCtx(async (ctx) => {
+      await ctx.actions.file.writeFileInProject(
+        'cypress/support/backgroundColor.css',
+        `.sample-bg { 
+          background: blue;
+        }`,
+      )
+
+      await ctx.actions.file.writeFileInProject(
+        'src/App.cy.jsx', `
+          import React from 'react'
+          import { App } from './App'
+          it('renders blue background', () => {
+            cy.mount(<App />)
+            cy.get('h1').should('have.css', 'background-color', 'rgb(0, 0, 255)')
+          })`,
+      )
+
+      await ctx.actions.file.writeFileInProject(
+        'src/App.jsx', `
+        import React from 'react'
+
+        export const App = () => {
+          return <h1 className='sample-bg'>Updated Hello World</h1>
+        }`,
+      )
+    })
+
+    // Now we only have one spec that asserts the background is blue, not red (which means a re-run was triggered.)
+    cy.get('.passed > .num').should('contain', 1)
+  })
 })
 
 describe('sourcemaps', () => {

npm/vite-dev-server/src/plugins/cypress.ts

@@ -133,13 +133,15 @@ export const Cypress = (
         // as soon as we find one of the specs, we trigger the re-run of tests
         for (const mod of moduleImporters.values()) {
           debug('handleHotUpdate - mod.file', mod.file)
+          // always re-run on supportFile changed
           if (mod.file === supportFilePath) {
-            debug('handleHotUpdate - support compile success')
-            devServerEvents.emit('dev-server:compile:success')
+            server.ws.send({
+              type: 'full-reload',
+            })
 
             // if we update support we know we have to re-run it all
             // no need to check further
-            return []
+            return
           }
 
           if (mod.file && specsPathsSet.has(mod.file)) {

tooling/v8-snapshot/cache/dev-linux/snapshot-meta.cache.json

@@ -3541,5 +3541,5 @@
     "./tooling/v8-snapshot/cache/dev-linux/snapshot-entry.js"
   ],
   "deferredHashFile": "yarn.lock",
-  "deferredHash": "844da7908a41692a3b04716c88e2f0cdad85ece6f94f6ab89fbd1ffe5c332fd2"
+  "deferredHash": "e48c44c628ea6b968dae0697bf1fb37e18bc69913676524512ca41dcff3a985a"
 }